Change of PrometheusTimeoutHeader const. #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It fixes #29 |
|
@danielgrabowski tanks for the PR! Glad i could help! |
|
@smartinov did you abandon the idea to tag versions of your image on Docker Hub? I want to know if I should use the "latest" one or you'll push the new version tag also which would be VERY preferred way since using "latest" images is a bad practice. |
|
@danielgrabowski definitely didn't. I just haven't had the time to create an automated CI for each tag push to do a release :'( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Prometheus now uses different timeout header name (https://github.com/prometheus/prometheus/blob/master/scrape/scrape.go#L610) than the one read by pagespeed_exporter (https://github.com/foomo/pagespeed_exporter/blob/master/handler/probe.go#L21). It causes failures of scrape for slower pages since the default timeout is 30s and it's not changed by Prometheus "scrape_timeout" configuration. This pull request fixes the issue.