-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite loop in error message #31
Comments
As a temporary fix, you can apply the following diff:
I'm not quite happy with the way the error message is rendered (it will split the code point in half and report multiple invalid ones for each byte, as only some code units are underlined), so I'll need to take some time to come up with a proper fix. |
Each byte is rendered in the output. Fixes #31.
Each byte is rendered in the output. Fixes #31.
Each byte is rendered in the output. Fixes #31.
Each byte is rendered in the output. Fixes #31.
Each byte is rendered in the output. Fixes #31.
Each byte is rendered in the output. Fixes #31.
Each byte is rendered in the output. Fixes #31.
Each byte is rendered in the output. Fixes #31.
This is now fixed, and it should report an error looking like this: https://lexy.foonathan.net/playground/?id=nEa7KjabK&mode=tree |
When parsing this file and displaying an error message related to the string
err-😂
vialexy_ext::report_error
, the output is12 │ err-⟨U+????⟩⟨U+????⟩
, but with the⟨U+????⟩
repeated for, at the very least, a long time.I've also tried it with a few other unicode characters and gotten the same result.
The text was updated successfully, but these errors were encountered: