Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
"Connection" tab not unfolding #1001
Operating octoprint web interface
Connections tab to display when clicked
Connections tab did not display when clicked
Version: 1.2.4 (master branch)
Marlin Integration branch
Latest chrome on OS X
No errors seemed to show up:
I have read the FAQ.
I would like to add that if you open the web interface while the printer is desconected then the connection tab is expanded by default, and you can expand and contract normally.
Using devel branch up to date and Google chrome on Windows 10.
I thought maybe it was a side effect of something I did in ScreenSquish, but I've disabled it and still repro. The reason it gets locked is that Collapse.transitioning gets stuck at 1 after #connection.collapse('hide') is called in the connection view model. And in bootstrap's Collapse.show it returns if transitioning is set. I haven't figured out why transitioning gets stuck at true yet.
It doesn't repro every time. My current operating theory is if the connection state comes back before knockout propagates the isVisible to show the wrapper element (for logged in user) then the collapse gets hidden, but the transition doesn't occur (because the wrapper is hidden) and the transition completion event never fires leaving it permanently in the the transitioning state.
Seems like bootstrap has a bug in that a collapse of an element that is hidden by some container.
Not sure the best way to fix it. I could try to fix the bootstrap bug to call the completion function if the element is hidden for some other reason or we could postpone collapsing the connection state until the login state is known.