Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add plugin configuration dialog to plugin manager #1062

Closed
mcanes opened this issue Sep 13, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@mcanes
Copy link

commented Sep 13, 2015

  1. What were you doing?
    Installing a plugin using the web interface plugin manager. Octoprint prompt a generic error.
    Something went wrong Please consult octoprint.log for details
  2. What did you expect to happen?
    Install the plugin. The plugin log printed this message.
    Installing plugin "EEPROM Marlin Editor" from https://github.com/amsbr/OctoPrint-EEprom-Marlin/archive/master.zip... Done!
  3. What happened instead?
    Octoprint try to find the command pip but in archlinux pip for python2 is pip2.
    So OctoPrint can't find the pip executable and failed.
  4. Branch & Commit or Version of OctoPrint:
    Version: 1.2.6 (master branch)
  5. Printer model & used firmware incl. version
    BCN3d+ with 0x00 firmware (marlin with some changes)
  6. Browser and Version of Browser, Operating
    System running Browser (if applicable - always
    include if unsure):
    Chrome 45.0.2454.85 (64-bit)
    Running on Linux.
    Octoprint running on RPI with archlinux.
  7. Link to octoprint.log on gist.github.com or pastebin.com
    (ALWAYS INCLUDE AND DO NOT TRUNCATE):
    http://pastebin.com/DX83S3Ly
  8. Link to contents of terminal tab or serial.log on
    gist.github.com or pastebin.com (if applicable - always
    include if unsure or reporting communication issues AND
    DO NOT TRUNCATE):
  9. Link to contents of Javascript console in the browser
    on gist.github.com or pastebin.com or alternatively a
    screenshot (if applicable - always include if unsure
    or reporting UI issues):
  10. Screenshot(s) showing the problem (if applicable - always include if unsure or reporting UI issues):

Notes:
Maybe we can use import pip and use the pip module instead of the pip command line.

Thanks.

@GitIssueBot

This comment has been minimized.

Copy link
Collaborator

commented Sep 13, 2015

Hi @mcanes,

It looks like there is some information missing from your ticket that will be needed in order to process it properly. Please take a look at the Contribution Guidelines and the page How to file a bug report on the project wiki, which will tell you exactly what your ticket has to contain in order to be processable.

If you did not intend to report a bug, please take special note of the title format to use as described in the Contribution Guidelines.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2015-09-27 16:40) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

@foosel

This comment has been minimized.

Copy link
Owner

commented Sep 13, 2015

You can override the pip command used to install plugins, here.

At the very beginning I in fact did use pip as a library like you suggest. I can't remember the exact problems I ran into with that that finally broke the camel's back, but I do remember that there were a lot of issues that were solved by switching to the external call approach that is now used.

@foosel

This comment has been minimized.

Copy link
Owner

commented Sep 13, 2015

Marked as request to add configuration dialog for pip command

@foosel foosel changed the title Error installing plugins using Archlinux (pip2) [Request] Add plugin configuration dialog to plugin manager Sep 13, 2015

@foosel

This comment has been minimized.

Copy link
Owner

commented Sep 22, 2015

Config dialog added in both devel and maintenance branch, will be included in 1.2.7 release.

@foosel foosel closed this Sep 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.