Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add events to file manager #1092

Closed
foosel opened this issue Oct 19, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@foosel
Copy link
Owner

commented Oct 19, 2015

The file manager currently doesn't trigger any events to notify other parts of the system about added/moved/removed etc files. The only way for e.g. plugins to get notified about added/uploaded files is listening to the Upload event, which only is triggered for actual file uploads, not for files added through other means, e.g. the watched folder.

We should have the file manager generate its own set of events for plugins such as the AutoSelect Plugin to hook into.

A first attempt at a list:

  • FileAdded
  • FileRemoved
  • FolderAdded
  • FolderRemoved

All those events would have a payload structured somewhat like this:

  • location: The identifier of the storage location of the affected file/folder
  • path: The path within the storage location to the affected file/folder
  • name: The name of the affected file/folder

For the SD card stuff we either need to have those events triggered in the comm layer for now, or don't trigger them at all, until that stuff is migrated to a proper StorageInterface implementation.

@Salandora do we also need events for copy/move or should it be sufficient to replicate those as *Added for a copy and *Removed + *Added for a move?

@Salandora

This comment has been minimized.

Copy link
Collaborator

commented Oct 19, 2015

Well I guess it would be sufficient to fire an added for copy and added + remived for move.

@foosel foosel changed the title [Brainstorming] Add events to file manager [Request] Add events to file manager Mar 8, 2017

@foosel foosel added this to the 1.3.3 milestone May 11, 2017

@foosel foosel closed this in b24851c May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.