New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watched function dies when using default folder #1120
Comments
Hi @MaxWinterstein, It looks like there is some information missing from your ticket that will be needed in order to process it properly. Please take a look at the Contribution Guidelines and the page How to file a bug report on the project wiki, which will tell you exactly what your ticket has to contain in order to be processable. If you did not intend to report a bug, please take special note of the title format to use as described in the Contribution Guidelines. I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2015-12-09 20:10) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Thank you! Best regards, PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them. |
@GitIssueBot you are the reason why people hate writing bug reports... oh this is so annoying...
I have read the FAQ. |
@MaxWinterstein you are the reason why people hate being human and devs hate being devs... oh this is so annoying... There is a fragging reason why bug report templates exist. And you are using a free open source software. If you're not even willing to take the 3 bloody minutes to use a report template - and expect the dev to take HIS/HER time to work though your BS - you do not even deserve to be provided with free software. |
@Murenius thanks for insulting me, this will help me / us a lot. is there anything useful you can provide here? |
"@GitIssueBot you are the reason why people hate writing bug reports... oh this is so annoying... " I only slightly changed your answer, so guess you were insulting as well. The useful part of my contribution was to point out that you left the pure factual level. I suggest getting back to that and in the future show some respect to a dev investing his time by at least filling out the bug report template properly. |
@Murenius you know that @GitIssueBot is an automatic system that only checks if the template is included? If you compare the second post of me against the first post you will see it does not include more information and was approved. So anyway, i will leave this useless conversation with you. It does not get us any usefull information and does not help me or the developers in any way. Since you seem not to be involved in octoprint in any way, and your fist post on github at all is the one insulting me, it is not worth the time to discuss something here with you. |
@MaxWinterstein Why I do not agree 100% with the choice of @Murenius words, he has a point. You apparently felt annoyed by the bot enough to feel it necessary to complain about it. You might be surprised to hear that I also don't like it very much - and I wrote it. The problem is, even more annoying than that bot is getting bug reports that
and having to run after all that information, revisiting each and every ticket continuously until either all data is there or it is clear that the OP won't be answering at all. And not only with one ticket but several dozens. With a noticeable increase over certain events like e.g. the holidays. So if you want to complain about something, complain about those users of OctoPrint please that have made it necessary to put some automated response system in place to basically hit them over the head with what is posted on top of every new issue form and also automating the revisiting of the tickets that aren't complete after two weeks. You can believe me when I tell you that I really wish that stupid bot wasn't necessary and people would just provide all data, always, with concise information about how to reproduce. Alas, that isn't the case, and the bot has at least reduced the time spent ticket management to levels where not only actual development (bug fixing, new features, ...) is possible again, it's actually fun helping people again. And with that please let us leave that behind and concentrate on the actual issue. Speaking of which, I haven't yet been able to reproduce it on current devel on my development system. edit Also not on |
@foosel i can totaly agree with you. peple use the issue system way too often for things that doent make sense. And wasting time in working on tickets that seems to be totally wrong is anoying at all. I also think this should not be even worth to discuss about. As i said, this is your house, i agree to your rules. i invested my coffee break to see if i can provide more information.
works fine. the file is move to the uploads folder and its working nice for the next cp. using sudo produces the problem:
produces the following output on console:
The problem itself is - for sure - the use of sudo. And my samba drive was possibly using the wrong file rights also. The problem is that octoprint is not looking in the watched folder any longer after this error output. It would be nice if the error would be printed in the console but octoprint would then work with the next file instead of crashing and not restarting the watched folder worker. edit: octoprint is able to move the file somehow. here is the created file (i stopped octoprint)
|
Then I misunderstood the problem. I understood "it crashed" as referring to the specific exception (a lot of people say "it crashed" when in fact they mean "logged an error"), not as "if some exception is raised in the watchdog due to problems external to OctoPrint, it stops working". The latter I can reproduce and is fixed in the above commit. |
i updated my devel to Version: 1.3.0.dev703+g47670a1 (devel branch) and tried with the same files. Now it works as expected. It throws an exception but does not die, and the next correct file is proccessed as supposed. Thanks for the quick reply & bugfix :) |
Perfect, closing then. Thanks for reporting! |
I switched to the devel branch to use the watched feature. I would like to throw a file into via samba and is should automatically show in the file list.
When i use the "default" folder the feature works one time and then crashes.
i changed the watch folder to /tmp/watched and reconfigured samba and everything works fine. It looks like the copy and analyze thread is working against each other or something like this.
i use
Gruß aus Stuttgart :)
The text was updated successfully, but these errors were encountered: