Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M28 response mistakingly gets additional ok injected #1272

Closed
foosel opened this issue Mar 10, 2016 · 0 comments
Closed

M28 response mistakingly gets additional ok injected #1272

foosel opened this issue Mar 10, 2016 · 0 comments
Assignees
@foosel
Labels
bug Issue describes a bug done Done but not yet released
Milestone
1.2.10

Comments

@foosel
Copy link
Member

foosel commented Mar 10, 2016

Problem

On starting an SD file transfer, the "Writing to file" response causes an additional "ok" to be injected. While this does speed up communication after wards significantly (parallel processing), it's wrong and might lead to severe communication issues further down the road if the additional "ok" causes OctoPrint to overflow the buffer of the printer.

Solution

Remove extra "ok".
@foosel foosel added the bug Issue describes a bug label Mar 10, 2016
@foosel foosel self-assigned this Mar 10, 2016
@foosel foosel added this to the 1.2.10 milestone Mar 10, 2016
@foosel foosel mentioned this issue Mar 10, 2016
Closed
@foosel foosel added the done Done but not yet released label Mar 10, 2016
@foosel foosel mentioned this issue Mar 10, 2016
Open
@foosel foosel closed this as completed in d393a67 Mar 16, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@foosel foosel

Labels
bug Issue describes a bug done Done but not yet released
Projects
None yet
Milestone
1.2.10
Development

No branches or pull requests
1 participant
@foosel