Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot see local files list #1300

Closed
AmedeeBulle opened this issue Mar 28, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@AmedeeBulle
Copy link

commented Mar 28, 2016

What were you doing?

This is rather stupid from my side, but if you enable 'Show only files on SD-Card', then disable SD-card support, you can't see your local files anymore.
This is per say not a big issue, but in a shared environment when one leaves Octoprint in that state, other users don't understand why they don't see their files...

To reproduce:

  1. Enable SD-Card support (if not active)
  2. Restart Octoprint (looks to me a restart is needed to activate / deactivate that setting)
  3. In the Files box, select 'Show only files on SD-Card'
  4. Disable SD-Card support
  5. Restart Octoprint

You don't see any files, and there is no option in the menu to show them (Unless you re-enable SD-Card support)

What did you expect to happen?

When SD-Card support is disabled, re-enable local files

What happened instead?

Empty files box ;) (Even if you upload a new file)

Branch & Commit or Version of OctoPrint

Version: 1.2.10.post0.dev0+g692166f (master branch)

Printer model & used firmware incl. version

N/A (Ultimaker Original)

Browser and Version of Browser, Operating System running Browser

N/A (Firefox 45.0.1)

Link to octoprint.log

N/A

Link to contents of terminal tab or serial.log

N/A

Link to contents of Javascript console in the browser

N/A

Screenshot(s) showing the problem:

N/A

I have read the FAQ.

@markwal

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2016

I retract this comment: In the devel branch when you do this, the file list is empty (as reported here), however, there is still an option to show the local files in the menu. Is that sufficient? In which case this is already fixed for a future release.

Actually if you refresh the page after restarting the server, the options disappear, they're removed in the jinja template.

@markwal markwal self-assigned this Mar 28, 2016

markwal added a commit that referenced this issue Mar 28, 2016

If no SD card support, remove SD file filter
When SD card support is disabled on the server, remove any client side
filtering to just SD files since there aren't any and there won't be UI
turn remove the filter either.  Should address #1300
@markwal

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2016

@foosel I fixed this in fix/noSdCardNoSdFilter branch and merged into maintenance. However, merging into devel brings 1a4c06d with it since the fix branch was based on maintenance and I wasn't sure you wanted that merged yet. I could cherry-pick or do the fix branch at a229cbf to get the fix into devel. Or, of course, merge maintenance. Sorry about that. Which would you prefer?

Additional info: my one line fix conflicts, of course, with the change to tertiary.

@foosel

This comment has been minimized.

Copy link
Owner

commented Mar 29, 2016

@markwal Merging anything from maintenance into devel that's not already there is totally fine - it usually is just caused by me not having yet merged any fixes or improvements up after a release.

Changes to the versioneer lookup table thingy are especially unproblematic since they relate to the branch, so merging anything to devel that doesn't change the devel line in the file is pretty much without consequence :)

@markwal

This comment has been minimized.

Copy link
Collaborator

commented Mar 29, 2016

183ca32 is in maintenance and devel, so this fix should show up in the next maintenance release (1.2.11).

@markwal markwal closed this Mar 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.