Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Cannot see local files list #1300
What were you doing?
This is rather stupid from my side, but if you enable 'Show only files on SD-Card', then disable SD-card support, you can't see your local files anymore.
You don't see any files, and there is no option in the menu to show them (Unless you re-enable SD-Card support)
What did you expect to happen?
When SD-Card support is disabled, re-enable local files
What happened instead?
Empty files box ;) (Even if you upload a new file)
Branch & Commit or Version of OctoPrint
Version: 1.2.10.post0.dev0+g692166f (master branch)
Printer model & used firmware incl. version
N/A (Ultimaker Original)
Browser and Version of Browser, Operating System running Browser
N/A (Firefox 45.0.1)
Link to octoprint.log
Link to contents of terminal tab or serial.log
Screenshot(s) showing the problem:
I have read the FAQ.
I retract this comment: In the devel branch when you do this, the file list is empty (as reported here), however, there is still an option to show the local files in the menu. Is that sufficient? In which case this is already fixed for a future release.
Actually if you refresh the page after restarting the server, the options disappear, they're removed in the jinja template.
@foosel I fixed this in fix/noSdCardNoSdFilter branch and merged into maintenance. However, merging into devel brings 1a4c06d with it since the fix branch was based on maintenance and I wasn't sure you wanted that merged yet. I could cherry-pick or do the fix branch at a229cbf to get the fix into devel. Or, of course, merge maintenance. Sorry about that. Which would you prefer?
Additional info: my one line fix conflicts, of course, with the change to tertiary.
@markwal Merging anything from
Changes to the versioneer lookup table thingy are especially unproblematic since they relate to the branch, so merging anything to