Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
octoprint.plugin.ProgressPlugin class plugins do not get 0% progress notify #1344
What were you doing?
Being so happy that Gina implemented a plugin I have wanted that I almost didn't notice that it wasn't resetting when starting a new print.
OctoPrint-DisplayProgress does a lovely job of allowing me to stand in front of the printer and see how far along we are. However, once it gets to 100%% and new print is started, the LCD indicator stays at 100%% until the new print gets to 1%(percent).
This is tracked back into OctoPrint proper, where the notification is doled out to plugins. Specifically
If progress is 0 then this obviously won't fire. I believe the intent of the code is to make sure there is progress/comms, which would be
What did you expect to happen?
To see 0%% when starting a new print!
What happened instead?
I saw the previous print's 100%% until I saw the new print hit 1%%
Branch & Commit or Version of OctoPrint
Version: 1.2.11 (master branch)
Printer model & used firmware incl. version
Browser and Version of Browser, Operating System running Browser
Link to octoprint.log
Link to contents of terminal tab or serial.log
Screenshot(s) showing the problem:
I have read the FAQ. Indeed I have%.
You seemed so confident, I didn't want to break your heart! Find a bug once, shame on me. Find a bug twice, shame on you.
Actually I thought it was working but you can also blame my printer, which had gotten so reliable that I'm never in there any more so I replaced the progress M117 with one that displayed the enclosure temperature from a DS18B20.