Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear print time estimate is displayed too early #1478

Closed
foosel opened this issue Sep 5, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@foosel
Copy link
Owner

commented Sep 5, 2016

Problem

Even if no other estimation sources are available, OctoPrint should only display the highly inaccurate linear estimate to the user if either 30min of the print have passed or 30% of the print job have been completed. In 1.2.15 the linear approximation is directly used instead of displaying "Calculating" until one of the above happens.

Solution

Make sure to actually convert passed time to minutes before comparison.

Already solved in 11bdc17, ticket created for documentation purposes.

@foosel foosel added this to the 1.2.16 milestone Sep 5, 2016

@foosel foosel self-assigned this Sep 5, 2016

@ManuGithubSteam

This comment has been minimized.

Copy link

commented Sep 19, 2016

Hi
another thing that happend to me: I print a part twice, same gcode file. It could know (save) the time needed the first time of printing and then simply display that. Now it does recalculate it....

@foosel

This comment has been minimized.

Copy link
Owner Author

commented Sep 19, 2016

Hm, it actually SHOULD save the print time: https://github.com/foosel/OctoPrint/blob/master/src/octoprint/printer/standard.py#L987

Did you update the GCODE file in any way or switched to another printer profile by any chance?

@ManuGithubSteam

This comment has been minimized.

Copy link

commented Sep 19, 2016

I just reuploaded it because i deleted to old one by accident but no
changes to the file. At least i remember none.

On 09/19/2016 12:45 PM, Gina Häußge wrote:

Hm, it actually SHOULD save the print time:
https://github.com/foosel/OctoPrint/blob/master/src/octoprint/printer/standard.py#L987

Did you update the GCODE file in any way or switched to another
printer profile by any chance?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#1478 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADS_4vHdtvdi5ydWf04bjHIpjfHgTsBgks5qrmfDgaJpZM4J0-y1.

@foosel

This comment has been minimized.

Copy link
Owner Author

commented Sep 19, 2016

ah, that explains it then. When you delete the old file, OctoPrint also throws away the metadata. It can't know if you'll reupload the file again, and if it just expected you to do that, it would use a lot of space for obsolete metadata and slowly fill up your disk with garbage. So, deletion or reupload (which is a deletion + recreation) -> metadata is reset.

@foosel

This comment has been minimized.

Copy link
Owner Author

commented Sep 24, 2016

Fixed in 1.2.16 which was released yesterday. Also fixed on devel.

@foosel foosel closed this Sep 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.