Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Delay on populate new bed target temperature #1543
What were you doing?
I'm working on a plugin, where i set the bed temperature by calling
What did you expect to happen?
I expected that
What happened instead?
Branch & Commit or Version of OctoPrint
1.2.16 (master branch) on rPi 2 with octopi
Printer model & used firmware incl. version
Marlin 1.0.2 Printer and Virtual Printer (Virtual Printer also on fresh VM installation of 1.2.16 master)
Link to octoprint.log
I have read the FAQ.
That was a prime example of two wrongs sometimes actually making a right.
As things were, when sending a temperature command to the printer and updating the tracked target internally, those changes were actually not forwarded to the printer instance until the next
This has now been fixed by a) making a copy of the data handed over from the client instead of just using it as is in the printer and b) triggering a temperature propagation after adjusting target values from sent commands.
I've tested this using this minimal plugin based on your provided example.
Note that the target temperature still will not updated immediately but only once the update command has been sent to the printer.
Fix is merged on both