Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback controls are broken in 1.3.0 #1588

Closed
foosel opened this issue Nov 11, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@foosel
Copy link
Owner

commented Nov 11, 2016

Problem

Feedback controls such as

- command: M114
  name: Get Position
  regex: X:([-+]?[0-9.]+) Y:([-+]?[0-9.]+) Z:([-+]?[0-9.]+) E:([-+]?[0-9.]+)
  template: 'Position: X={0}, Y={1}, Z={2}, E={3}'

no longer produce the request output. On closer look, they are not properly enriched with the expected additional regex processing data on retrieval from the settings backend and hence ignored by the actual feedback matching code.

Reason is that the default preprocessors are not properly applied in the current settings implementation. This error was introduced when refactoring those parts for settings overlay support.

Solution

Make sure the default preprocessors are utilized on get and set operations if no specific ones are provided.

See also

@foosel foosel added this to the 1.3.0 milestone Nov 11, 2016

@foosel foosel self-assigned this Nov 11, 2016

foosel added a commit that referenced this issue Nov 11, 2016

Use default settings preprocessors if none are provided
Re-enables feedback controls.

Closes #1588
@foosel

This comment has been minimized.

Copy link
Owner Author

commented Nov 25, 2016

1.3.0rc2 is out

@foosel

This comment has been minimized.

Copy link
Owner Author

commented Nov 28, 2016

@ovidiu I saw you commented that it didn't work, but the comment vanished - did it work out after all then and you deleted it or what happened there? :) It definitely does work for me...

@MoonshineSG

This comment has been minimized.

Copy link

commented Nov 28, 2016

Yes, it appears I can type faster than my printer can respond. Sorry about that. It works.

@foosel

This comment has been minimized.

Copy link
Owner Author

commented Dec 1, 2016

Closing this then, as it's fixed with 1.3.0rc2 (and I actually had intended to close it with my corresponding comment, don't know what went wrong there)

@foosel foosel closed this Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.