Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unable to delete printer profiles via the trashcan icon. #1734

Closed
ayourk opened this issue Jan 25, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@ayourk
Copy link

commented Jan 25, 2017

What were you doing?

Awhile back I added a printer I intended on purchasing. I never really did purchase this printer, so I wanted to delete that printer profile from OctoPrint. OctoPrint does not register (as far as I can tell) that the printer profile is deleted.

To recreate: Create a printer profile. Try to delete that profile. Deletion fails to register.

What did you expect to happen?

I expected the list of printer profiles to refresh without the printer profile I chose to delete.

What happened instead?

OctoPrint appeared to process something, then nothing in the list changed.

Branch & Commit or Version of OctoPrint

OctoPrint v1.3.1, but this has been happening for several versions now.
OctoPrint is running on Ubuntu Mate 16.04 on a Raspberry Pi 3.

Printer model & used firmware incl. version

Original Prusa i3 MK2 with 1.3.10a2 firmware (customized)

Browser and Version of Browser, Operating System running Browser

I am using Google Chrome (stable) on Ubuntu Linux 16.04 LTS.

Link to octoprint.log

https://gist.github.com/ayourk/ae91f9af56b194ef1d42aabe7a4c988f

Link to contents of terminal tab or serial.log

Not relevant.

Link to contents of Javascript console in the browser

https://gist.github.com/ayourk/361b1333c8305854ee7b8a8404308f21

I have read the FAQ.

@ayourk ayourk changed the title Unable to delete printer profiles via the trashcan icon. [Bug] Unable to delete printer profiles via the trashcan icon. Feb 5, 2017

@foosel

This comment has been minimized.

Copy link
Owner

commented Feb 15, 2017

If it is the printer profile with the identifier "_default" you are trying to delete, that is not a bug but a misguided feature that I'll have to change.

Sadly your log does not appear to contain an actual deletion attempt (or I'm just blind right now) so I can't verify that right now - could you please elaborate?

@ayourk

This comment has been minimized.

Copy link
Author

commented Feb 15, 2017

Here is a picture of my Printer Profiles: http://i.imgur.com/aK4VxMp.png

I'm trying to delete the MakerGear M2 from the list. The interface appears to go through the motions of attempting to delete the printer profile, but the listing never disappears.

@foosel

This comment has been minimized.

Copy link
Owner

commented Feb 17, 2017

Sadly that screenshot doesn't help to determine if the profile in question has the _default identifier mentioned above. Could you please check what it says when you click on that MakerGear M2 profile's little pencil icon to edit it in the Identifier field?

image

If it says _default like in the above screenshot, it's as I thought and you are trying to delete what you defined as the default profile, and that currently can't be deleted. Has to be changed, was a stupid design decision when I introduced printer profiles.

@ayourk

This comment has been minimized.

Copy link
Author

commented Feb 17, 2017

I can confirm it says "_default" in the Identifier field. How do I change that?

@ayourk

This comment has been minimized.

Copy link
Author

commented Feb 17, 2017

I would have thought that the "STAR" symbol followed the default printer profile.

@foosel

This comment has been minimized.

Copy link
Owner

commented Feb 17, 2017

You currently can't change that. Identifiers are not modifiable. As I said, I made a wrong design decision here. The "star" does follow the default printer profile, the problem rather is that the profile with the identifier "_default" (both are NOT necessarily the same) is stored differently than the others and currently doesn't support deletion. It's also not something I can easily fix because that would cause problems in other places. So that might take a while to allow, sorry.

@ayourk

This comment has been minimized.

Copy link
Author

commented Feb 17, 2017

I think I fixed it on my end by manually editing config.yaml while octoprint was shut down.

@ayourk ayourk closed this Feb 17, 2017

foosel added a commit that referenced this issue Mar 21, 2017

Handle default printer profile like all other profiles
It now resides in a file on disk and can be deleted. If the profile
configured as default is not available (e.g. due to having been
manually deleted, or on first start), the default profile as defined
in the profile manager will be written as _default and that will be
used/set as default.

On first start after this change gets applied, OctoPrint will migrate
the old "default overlay" residing in config.yaml to a file on disk
and delete the old entries in config.yaml.

Solves core reason of #1734

foosel added a commit that referenced this issue Mar 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.