Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printer command timeout appear to be corrupting internal print metadata #1837

Closed
fraschetti opened this issue Mar 25, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@fraschetti
Copy link

commented Mar 25, 2017

What were you doing?

My printer had a new firmware available which caused me to acknowledge physically at the printer each time I started a print via Octoprint.
If I didn't physically press the button on my printer, a timeout error occurs with OctoPrint, the print is marked as failed but the print information (which is normally otherwise available on the failed event) is unavailable.

What did you expect to happen and what happened instead?

It should be business as usual interms of the PrintFailed event having full knowledge of the print that failed. The exception (see below) is likely the cause.

Branch & Commit or Version of OctoPrint

OctoPrint 1.3.2 (master branch)

Operating System running OctoPrint

OctoPi 0.13

Printer model & used firmware incl. version

(after I applied my firmware update)
Original Prusa i3 MK2
Marlin V1.0.2; Sprinter/grbl mashup for gen6

Browser and Version of Browser, Operating System running Browser

N/A

Link to octoprint.log

Apologies but I only copied the relevant log entries and have since updated my firmware so I cannot reproduce.

https://gist.github.com/fraschetti/831b0487faa3c14de36a7631eed49144

Link to contents of terminal tab or serial.log

I didn't capture this information before updating my firmware (which makes the issue unreproducable)

Link to contents of Javascript console in the browser

N/A

Screenshot(s) or video(s) showing the problem:

N/A

I have read the FAQ.

@GitIssueBot

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2017

Hi @fraschetti,

It looks like there is some information missing from your bug report that will be needed in order to solve the problem. Read the Contribution Guidelines which will provide you with a template to fill out here so that your bug report is ready to be investigated (I promise I'll go away then too!).

If you did not intend to report a bug but wanted to request a feature or brain storm about some kind of development, please take special note of the title format to use as described in the Contribution Guidelines.

Please do not abuse the bug tracker as a support forum - if you have a question or otherwise need some kind of help or support refer to the Mailinglist or the G+ Community instead of here.

Also make sure you are at the right place - this is the bug tracker of the official version of OctoPrint, not the Raspberry Pi image OctoPi nor any unbundled third party OctoPrint plugins or unofficial versions. Make sure too that you have read through the Frequently Asked Questions and searched the existing tickets for your problem - try multiple search terms please.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2017-04-08 18:10 UTC) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Remember, the less time the devs have to spend running after information on tickets, the more time they have to actually solve problems and add awesome new features. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

@foosel

This comment has been minimized.

Copy link
Owner

commented Mar 27, 2017

It's not corrupting it, but it's trying to access data that is no longer available because it's been reset from a different thread.

I should have solved that now through the above commit, currently on the maintenance branch, soon on the devel branch as well and in any case to be released with 1.3.3.

@foosel foosel added this to the 1.3.3 milestone Mar 27, 2017

@foosel

This comment has been minimized.

Copy link
Owner

commented May 31, 2017

1.3.3 was just released.

@foosel foosel closed this May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.