Clear upload data when Aborting cura profile upload modal. #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes OctoPrint#1893 . Also, only bind click to the "Confirm" button once instead of binding and unbinding it for each file. Binding it just once seems cleaner.
|
I've cherry picked this as f5fad51 to Since Github currently doesn't pick up cherry picks properly, I'll now close this manually since it's merged. It won't be marked as merged though, please don't be alarmed by that. As a side note, I updated the PR guidelines a while ago, PRs for bug fixes may now also be done against |
|
Enjoy. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1893 .
Also, only bind click to the "Confirm" button once instead of binding and unbinding it for each file. Binding it just once seems cleaner.
What does this PR do and why is it necessary?
Clear the upload data before loading the cura profile modal dialog so that the dialog contents are consistent with the upload data.
How was it tested? How can it be tested by the reviewer?
Follow procedure in the bug.
Any background context you want to provide?
In the bug.
What are the relevant tickets if any?
#1893