[Request] "Copy" button for API key

[b-morgan]

When attempting to "copy" the API key, nothing happens in Chrome and Firefox but it works with Edge. I do have LastPass (but Edge doesn't support it).

[GitIssueBot]

Hi @b-morgan,

It looks like there is some information missing from your bug report that will be needed in order to solve the problem. Read the Contribution Guidelines which will provide you with a template to fill out here so that your bug report is ready to be investigated (I promise I'll go away then too!).

If you did not intend to report a bug but wanted to request a feature or brain storm about some kind of development, please take special note of the title format to use as described in the Contribution Guidelines.

Please do not abuse the bug tracker as a support forum - if you have a question or otherwise need some kind of help or support refer to the Mailinglist or the G+ Community instead of here.

Also make sure you are at the right place - this is the bug tracker of the official version of OctoPrint, not the Raspberry Pi image OctoPi nor any unbundled third party OctoPrint plugins or unofficial versions. Make sure too that you have read through the Frequently Asked Questions and searched the existing tickets for your problem - try multiple search terms please.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2017-08-18 14:10 UTC) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Remember, the less time the devs have to spend running after information on tickets, the more time they have to actually solve problems and add awesome new features. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

[b-morgan]

What were you doing?

When attempting to "copy" the API key, nothing happens in Chrome and Firefox but it works with Edge. I do have LastPass (but Edge doesn't support it).

What did you expect to happen?

Key in clipboard.

What happened instead?

Nothing.

Did the same happen when running OctoPrint in safe mode?

[Try to reproduce your problem in safe mode. You can find information
on how to enable safe mode in the Contribution Guidelines.]

Branch & Commit or Version of OctoPrint

1.3.4

Operating System running OctoPrint

OctoPi, version 0.14.0

Printer model & used firmware incl. version

Lulzbot TAZ 6, RAMBo 1.3L, Marlin 1.0.2.22

Browser and Version of Browser, Operating System running Browser

Windows 10 Professional, Chrome 60.0.3112.90 (Official Build) (64-bit), Firefox 54.0.1 (64-bit)

Link to octoprint.log

octoprint.zip

[markwal]

I think this is a security fix it some browsers. Some webapps (OneNote comes to mind) pop up a message when you click the copy button that says you have to use Ctrl-C or the right click menu.

[b-morgan]

I tried ctrl-C and right-click Copy. Neither worked (in Chrome and Firefox). Both worked in Edge.

[ntoff]

Works ok here on chrome running on windows 10 pro

double click the key (or click and drag) to highlight it all -> right click -> copy. Does that not work for you?

[b-morgan]

To reiterate what I said in my previous posts, on Windows 10 Pro, Chrome 60.0.3112 I can highlight the key but right-click Copy does not work for me. Same results using Firefox (right-click Copy doesn't work).

With Microsoft's Edge browser, I can highlight and right-click Copy without any issues.

I think a key piece of this puzzle is that I have LastPass installed which has addons for Chrome and Firefox but does not have one for Edge (or rather, Edge doesn't yet support addons). I did try disabling LastPass in Firefox but that did NOT change the symptoms (right-click Copy doesn't work).

[ntoff]

Ok well it works in chrome but I just tried firefox and even without lastpass I can't copy the key either. What I CAN do, is drag it onto notepad++ which inserts it into a document and then leaves OctoPrint hanging in limbo on the upload overlay so I guess bug confirmed? But only for firefox. Chrome still works ok for me (I don't use lastpass).

[KC703]

Right clicking in both Chrome (Version 60.0.3112.90 (Official Build) (64-bit)) and Edge allow me to copy the API Key... Ctrl+C works also when the key is highlighted. I use the Lastpass plugin for both Chrome and Edge (not sure if this is a plugin, could be the Lastpass app from the MS Store). Just tried Fiefox and the API key won't highlight...

…

On Sat, Aug 5, 2017 at 1:41 AM, ntoff ***@***.***> wrote: Ok well it works in chrome but I just tried firefox and even without lastpass I can't copy the key either. What I CAN do, is drag it onto notepad++ which inserts it into a document and then leaves OctoPrint hanging in limbo on the upload overlay so I guess bug confirmed? But only for firefox. Chrome still works ok for me (I don't use lastpass). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2056 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHXrAkhmHLwuMJ4CCjSM9F6Z7kFLIG47ks5sVACYgaJpZM4OtwRn> .

[b-morgan]

I'm a little embarrassed. I just tried Chrome again and it works. That leaves us with a Firefox issue which you all have confirmed.

[ntoff]

I wonder if a little "copy" button should be placed next to the API key, allowing someone to just press that to copy the key into the clipboard.

[GitIssueBot]

Since apparently some of the required information is still missing, I'm closing this now, sorry. Feel free to request a reopen of this or create a new issue once you can provide all required information.
This is nothing personal. Thank you for your collaboration.

[foosel]

I have no idea what Firefox' problem is here, but regardless, I've added a bunch of copy buttons to the various API key fields (Settings > API, Settings > Access Control, User settings).

Pushed to maintenance, soon devel and to be released with 1.3.6.

[sepal]

Just had this issue as well and did a little bit of research:
Apperently this is new in Firefox Quantum (aka 57.0) and is a bug fix, since the HTML5 standard specifies that users shouldn't be able to interact with a disabled inputs.
The API key input should instead use the read only attribute, which allows to copy from, but not manipulate the form elements.

[foosel]

The API key input should instead use the read only attribute, which allows to copy from, but not manipulate the form elements.

And that was changed in cf25291 and will be part of 1.3.6 as well.

[foosel]

Closing because 1.3.6 was just released.