Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Octoprint Timelapse #2067

Closed
ComicBit opened this issue Aug 11, 2017 · 8 comments
Closed

[Request] Octoprint Timelapse #2067

ComicBit opened this issue Aug 11, 2017 · 8 comments
Labels
done Done but not yet released request Feature request

Comments

@ComicBit
Copy link

Hello, i just found a crashed print because of Z Based timelapse on Vase Mode. Essentially Octoprint triggers the capture on Z-Changing but this thing obviusly triggers continuosly on Vase Mode, it can corrupt a print (as happened to me just now). I know that the simpler solution is changing the mode but isn't possible to make an automatic system that recognize a vase mode and prompt a proposal of changing the Timelapse Mode?

@GitIssueBot GitIssueBot added the request Feature request label Aug 11, 2017
@FHeilmann
Copy link
Contributor

The page where you configure timelapses EXPLICITLY states to not use it for vases.

How would octoprint detect a vase mode from G-Code?

@ComicBit
Copy link
Author

Yes i know, but you can ocasionally forget it.. For example Simplify3D write this on the gcode spiralVaseMode,1

Octoprint will possibly search for this strings

@ntoff
Copy link
Contributor

ntoff commented Aug 12, 2017

Not every slicer puts that info there though, some might not put any info at all so it'd be a feature that works sometimes, maybe, but only under very certain circumstances.

@foosel
Copy link
Member

foosel commented Aug 21, 2017

OctoPrint can't search for these strings since

  • they are not standardized in any way
  • in order to be aware of them OctoPrint first has to read the file fully - this takes time and CPU resources and if you hit "Print" before that is done, you are back to square one

What could be done though is rate-limiting the z-change triggers, basically not doing another snapshot if the last one was less than n seconds ago. The tricky bit will be to find a good default value here, but that should be do-able (and could also be made configurable to accommodate corner cases)

@foosel foosel added this to the 1.3.6 milestone Aug 21, 2017
foosel added a commit that referenced this issue Oct 26, 2017
This is to prevent against an endless stream of snapshots when
accidentally printing a vase mode file despite the warning.

As mentioned in #2067
foosel added a commit that referenced this issue Oct 26, 2017
@foosel
Copy link
Member

foosel commented Oct 26, 2017

Rate limiting is now available on maintenance. The default minimum delay between snapshots is 5s but this can also be changed via the configuration dialog:

image

The minimum is 1s.

Will be released with 1.3.6.

@foosel foosel added the done Done but not yet released label Oct 26, 2017
@ComicBit
Copy link
Author

As always an awesome solution, thanks for your job!

@ntoff
Copy link
Contributor

ntoff commented Oct 26, 2017

What's "reset to active configuration"? Is that like "reload configuration from disk" if you've changed something and want to go back to the way it's set in config.yaml?

@foosel
Copy link
Member

foosel commented Oct 27, 2017

Basically, "load whatever's the currently active configuration". That doesn't necessarily need to be what's in config.yaml, since there it will only be stored if you "save as default", but rather what the server has currently set as active timelapse configuration in memory. In a nutshell, click that button and it reverts to what the form was showing when you loaded the page or when you last clicked "save changes".

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
done Done but not yet released request Feature request
Projects
None yet
Development

No branches or pull requests

5 participants