Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Allow git+https URIs for plugins #2104

Closed
JohnMH opened this issue Aug 31, 2017 · 5 comments
Closed

[Request] Allow git+https URIs for plugins #2104

JohnMH opened this issue Aug 31, 2017 · 5 comments
Labels
done Done but not yet released request Feature request

Comments

@JohnMH
Copy link

JohnMH commented Aug 31, 2017

OctoPrint currently only allows http or https URLs to be added as plugins. This is an issue for some servers, such as cgit installations. This should be as simple as allowing URLs prefixed with "git+", which pip has special handling for.

@GitIssueBot
Copy link

Hi @JohnMHarrisJr,

It looks like there is some information missing from your bug report that will be needed in order to solve the problem. Read the Contribution Guidelines which will provide you with a template to fill out here so that your bug report is ready to be investigated (I promise I'll go away then too!).

If you did not intend to report a bug but wanted to request a feature or brain storm about some kind of development, please take special note of the title format to use as described in the Contribution Guidelines.

Please do not abuse the bug tracker as a support forum - if you have a question or otherwise need some kind of help or support refer to the Mailinglist or the G+ Community instead of here.

Also make sure you are at the right place - this is the bug tracker of the official version of OctoPrint, not the Raspberry Pi image OctoPi nor any unbundled third party OctoPrint plugins or unofficial versions. Make sure too that you have read through the Frequently Asked Questions and searched the existing tickets for your problem - try multiple search terms please.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2017-09-14 00:30 UTC) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Remember, the less time the devs have to spend running after information on tickets, the more time they have to actually solve problems and add awesome new features. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

@GitIssueBot GitIssueBot added the incomplete Issue template has not been fully filled out, no further processing until fixed label Aug 31, 2017
@foosel foosel changed the title Allow git+https URIs for plugins [Request] Allow git+https URIs for plugins Sep 28, 2017
@foosel foosel added request Feature request and removed incomplete Issue template has not been fully filled out, no further processing until fixed labels Sep 28, 2017
@foosel
Copy link
Member

foosel commented Sep 28, 2017

OctoPrint currently only allows http or https URLs to be added as plugins

What location are you referring to here? This?

image

@foosel foosel added the needs information More information is needed to further process this issue or PR label Sep 28, 2017
@JohnMH
Copy link
Author

JohnMH commented Sep 28, 2017

Yes, that's the portion I'm referring to. Sorry for the lack of info.

foosel added a commit that referenced this issue Oct 2, 2017
@foosel foosel added done Done but not yet released and removed needs information More information is needed to further process this issue or PR labels Oct 2, 2017
@foosel foosel added this to the 1.3.6 milestone Oct 2, 2017
@foosel
Copy link
Member

foosel commented Oct 2, 2017

Implemented in the above commit, pushed to maintenance, soon devel, will be part of 1.3.6.

@foosel
Copy link
Member

foosel commented Dec 12, 2017

Closing because 1.3.6 was just released.

@foosel foosel closed this as completed Dec 12, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
done Done but not yet released request Feature request
Projects
None yet
Development

No branches or pull requests

3 participants