Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way of calling analysis process can cause import errors in third party libraries used therein #2135

Closed
foosel opened this issue Oct 2, 2017 · 1 comment
Assignees
Labels
bug Issue describes a bug done Done but not yet released
Milestone

Comments

@foosel
Copy link
Member

foosel commented Oct 2, 2017

Problem

As mentioned in #2095 (comment), there exists an import problem when libyaml is installed on the system and hence the yaml dependency utilizes its native extension, which imports platform. Since by calling gcodeInterpreter.py the python lookup path is modified to include the directory this file resides in, platform no longer resolves to the global platform module but instead octoprint.util.platform.

This of course causes huge issues.

Solution

Change call of GCODE analysis tool to not cause issues with the python lookup path. Turning it into its own subcommand of the octoprint executable and then launching that via python -m octoprint appears to work just fine.

Implemented in c84e199

@foosel foosel added done Done but not yet released bug Issue describes a bug labels Oct 2, 2017
@foosel foosel added this to the 1.3.5 milestone Oct 2, 2017
@foosel foosel self-assigned this Oct 2, 2017
@foosel
Copy link
Member Author

foosel commented Oct 17, 2017

1.3.5 was released yesterday.

@foosel foosel closed this as completed Oct 17, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue describes a bug done Done but not yet released
Projects
None yet
Development

No branches or pull requests

1 participant