New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale dependent sorting order of wizard breaks functionality if ACL setup is not done first #2140

Closed
foosel opened this Issue Oct 4, 2017 · 0 comments

Comments

1 participant
@foosel
Owner

foosel commented Oct 4, 2017

Problem

This issue was identified over the course of #2095 and #2137.

OctoPrint sorts the sub wizards in the setup wizard by the locale dependent title. Sub wizards marked as mandatory are sorted first, then optional sub wizards follow. This leads to the sub wizard order of

  • Access Control
  • Online connectivity check

when english locale is selected. However, in a different locale (e.g. german), ACL setup might get sorted AFTER the mandatory online connectivity check:

  • Onlineprüfung (Online connectivity check)
  • Zugangsbeschränkung (Access Control)

That in turn then can't be completed because the API it requires for this denies access as long as ACL setup has not been done yet. The result is that the whole wizard can never be completed.

Solution

It must be ensured that the ACL sub wizard - if required - ALWAYS comes first. Normally we could use the sorting order configuration for that, but in this particular case it is safer to actually hard code this as a special sorting algorithm right into the template processing in the core application, since otherwise a vendor or user might break initial setup simply by configuring a different order.

@foosel foosel added this to the 1.3.5 milestone Oct 4, 2017

@foosel foosel self-assigned this Oct 4, 2017

@foosel foosel added the status:solved label Oct 4, 2017

@foosel foosel closed this in 25c56a5 Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment