Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Locale dependent sorting order of wizard breaks functionality if ACL setup is not done first #2140
OctoPrint sorts the sub wizards in the setup wizard by the locale dependent title. Sub wizards marked as mandatory are sorted first, then optional sub wizards follow. This leads to the sub wizard order of
when english locale is selected. However, in a different locale (e.g. german), ACL setup might get sorted AFTER the mandatory online connectivity check:
That in turn then can't be completed because the API it requires for this denies access as long as ACL setup has not been done yet. The result is that the whole wizard can never be completed.
It must be ensured that the ACL sub wizard - if required - ALWAYS comes first. Normally we could use the sorting order configuration for that, but in this particular case it is safer to actually hard code this as a special sorting algorithm right into the template processing in the core application, since otherwise a vendor or user might break initial setup simply by configuring a different order.