Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling errors in "Approx. Total Print Time" hover message #2167

Closed
arose62 opened this issue Oct 22, 2017 · 1 comment
Closed

Spelling errors in "Approx. Total Print Time" hover message #2167

arose62 opened this issue Oct 22, 2017 · 1 comment
Labels
done Done but not yet released

Comments

@arose62
Copy link

arose62 commented Oct 22, 2017

What were you doing?

Hovering mouse over "Approx. Total Print Time" in the "State" region.

What did you expect to happen?

A pop-up message saying "Estimated total print time based on statistical analysis of past prints"

What happened instead?

A pop-up message saying "Estimated total print time base on statical analysis or past prints"
3 spelling and/or grammatical errors: "base" should be "based", "statical" should be "statistical", and "or" probably should be "of".

Did the same happen when running OctoPrint in safe mode?

Yes

Branch & Commit or Version of OctoPrint

OctoPrint 1.3.4 (master branch)

Operating System running OctoPrint

OctoP Jessie.

Printer model & used firmware incl. version

Cocoon Touch

Browser and Version of Browser, Operating System running Browser

Google Chrome Version 46.0.2490.86

Link to octoprint.log

Link to contents of terminal tab or serial.log

Link to contents of Javascript console in the browser

Screenshot(s)/video(s) showing the problem:

spellingerrors

I have read the FAQ.

@foosel
Copy link
Member

foosel commented Oct 23, 2017

Thanks. "base" indeed was a typo, "statical" a horrible mixture of "static" and "statistical", both of which more misleading than accurate, and "or" is actually correct (it's analysis of the file or past prints).

Changed to "Estimated total print time based on analysis of the file or past prints" on maintenance, soon devel, will be released with 1.3.6.

@foosel foosel added the done Done but not yet released label Oct 23, 2017
@foosel foosel added this to the 1.3.6 milestone Oct 23, 2017
@foosel foosel closed this as completed in c8e5820 Dec 12, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
done Done but not yet released
Projects
None yet
Development

No branches or pull requests

2 participants