Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make API key use "readonly" instead of "disabled" so it is selectable / copyable #2196

Closed
aplocher opened this issue Nov 1, 2017 · 3 comments
Labels
incomplete Issue template has not been fully filled out, no further processing until fixed

Comments

@aplocher
Copy link

aplocher commented Nov 1, 2017

Currently the API key is in a textbox marked as "disabled". This makes it impossible to select and copy in Firefox (and probably every other browser). The only way to enter it elsewhere is to type each character or use the QR Scan feature.

By marking the input field as Readonly instead of Disabled, it will remain selectable.

Alternatively, a separate javascript link/button which offers to "copy" would work, too.

I was kinda torn on whether this should be filed as a bug or feature request. I can't imagine that not being able to copy the API key is intentional. The version I'm using is OctoPrint 1.3.5 (master branch).

Thanks

@GitIssueBot
Copy link

Hi @aplocher,

It looks like there is some information missing from your bug report that will be needed in order to solve the problem. Read the Contribution Guidelines which will provide you with a template to fill out here so that your bug report is ready to be investigated (I promise I'll go away then too!).

If you did not intend to report a bug but wanted to request a feature or brain storm about some kind of development, please take special note of the title format to use as described in the Contribution Guidelines.

Please do not abuse the bug tracker as a support forum - if you have a question or otherwise need some kind of help or support refer to the Mailinglist or the G+ Community instead of here.

Also make sure you are at the right place - this is the bug tracker of the official version of OctoPrint, not the Raspberry Pi image OctoPi nor any unbundled third party OctoPrint plugins or unofficial versions. Make sure too that you have read through the Frequently Asked Questions and searched the existing tickets for your problem - try multiple search terms please.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2017-11-15 21:20 UTC) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Remember, the less time the devs have to spend running after information on tickets, the more time they have to actually solve problems and add awesome new features. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

@GitIssueBot GitIssueBot added the incomplete Issue template has not been fully filled out, no further processing until fixed label Nov 1, 2017
@ntoff
Copy link
Contributor

ntoff commented Nov 2, 2017

#2056 API key will be getting its very own shiny "copy to clipboard" button in a future release of OctoPrint.

@foosel
Copy link
Member

foosel commented Nov 2, 2017

That copying doesn't work due to the disabled field is indeed a Firefox-only problem as far as I am aware, see also #2056. As mentioned by @ntoff, a copy button has already been added and will be rolled out with 1.3.6.

I'm closing this since it's pretty much a duplicate of the aforementioned ticket, comments are still possible though.

@foosel foosel closed this as completed Nov 2, 2017
foosel added a commit that referenced this issue Nov 27, 2017
Further fix for FF issues with disabled input fields as tracked in
#2056 and #2196.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
incomplete Issue template has not been fully filled out, no further processing until fixed
Projects
None yet
Development

No branches or pull requests

4 participants