Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movement distance buttons don't disable with the other buttons on the control tab #2232

Closed
ntoff opened this issue Nov 22, 2017 · 1 comment
Labels
done Done but not yet released improvement Improving functionality, behaviour, UX, ...

Comments

@ntoff
Copy link
Contributor

ntoff commented Nov 22, 2017

What were you doing?

Testing something

Ideally provide exact steps to follow in order to reproduce your problem:

  1. load gcode
  2. press print
  3. notice the distance selection buttons don't disable along with the direction buttons

Alternatively:

  1. disconnect from the printer
  2. notice the distance selectors are still active

What did you expect to happen?

That the distance buttons follow the same data-bind="enable: isOperational() && !isPrinting() && loginState.isUser(), ... as the movement direction buttons.

What happened instead?

The distance selectors only care about whether a user is logged in data-bind="enable: $root.loginState.isUser(), ... and ignore print status and connection status.

Did the same happen when running OctoPrint in safe mode?

Yes

Branch & Commit or Version of OctoPrint

OctoPrint 1.3.5 (master branch)

Operating System running OctoPrint

linux mint 18

Printer model & used firmware incl. version

virtual printer / no printer

Browser and Version of Browser, Operating System running Browser

image

Link to octoprint.log

n/a

Link to contents of terminal tab or serial.log

Not a serial issue

Link to contents of Javascript console in the browser

Not a javascript issue

Screenshot(s)/video(s) showing the problem:

printing:

image

disconnected:

image

I have read the FAQ.

@foosel foosel added this to the 1.3.6 milestone Nov 29, 2017
@foosel foosel added the improvement Improving functionality, behaviour, UX, ... label Nov 29, 2017
@foosel
Copy link
Member

foosel commented Nov 29, 2017

Good point. Has been changed on maintenance, soon devel, will be part of 1.3.6.

@foosel foosel added the done Done but not yet released label Nov 29, 2017
@foosel foosel closed this as completed in 0560e9d Dec 12, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
done Done but not yet released improvement Improving functionality, behaviour, UX, ...
Projects
None yet
Development

No branches or pull requests

2 participants