Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect grammar on Print Time Left label #2242

Closed
cmadson opened this issue Nov 25, 2017 · 1 comment
Closed

Incorrect grammar on Print Time Left label #2242

cmadson opened this issue Nov 25, 2017 · 1 comment
Labels
bug Issue describes a bug done Done but not yet released

Comments

@cmadson
Copy link

cmadson commented Nov 25, 2017

What were you doing?

Printing a large file that spanned multiple days

What did you expect to happen?

When Print Time Left reached 1 day, label should read "1 day"

What happened instead?

label reads "1 days"

Did the same happen when running OctoPrint in safe mode?

I did not attempt this

Branch & Commit or Version of OctoPrint

1.3.5 Master

Operating System running OctoPrint

OctoPi v 0.14.0

Printer model & used firmware incl. version

Lulzbot Taz 6 Marlin_Oliveoil_Tilapia_v1.0.2.22_60d344d.hex

Browser and Version of Browser, Operating System running Browser

Safari 10.1

Link to octoprint.log

https://gist.github.com/cmadson/f323e04041942dd894395fad2c73300f

Link to contents of terminal tab or serial.log

Not included

Link to contents of Javascript console in the browser

Not included

Screenshot(s)/video(s) showing the problem:

https://www.dropbox.com/s/gzwi25ncq67ruft/screenshot.png?dl=0

I have read the FAQ.

@foosel
Copy link
Member

foosel commented Nov 27, 2017

Thanks for reporting that. Seems to be caused by anything over 24 hours. Fixed on maintenance, soon devel, will be released with 1.3.6.

@foosel foosel added done Done but not yet released bug Issue describes a bug labels Nov 27, 2017
@foosel foosel added this to the 1.3.6 milestone Nov 27, 2017
@foosel foosel closed this as completed in a2d3801 Dec 12, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue describes a bug done Done but not yet released
Projects
None yet
Development

No branches or pull requests

2 participants