Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add documentation for dimensions and printingarea in gcodeAnalysis data model #2463

Closed
tedder opened this issue Mar 5, 2018 · 2 comments
Labels

Comments

@tedder
Copy link
Contributor

tedder commented Mar 5, 2018

GET /api/files/[path+file] returns the gcodeAnalysis, as documented in file_information:files of the common data model. The gcodeAnalysis returns filament info and estimated print time. But it also returns the printingarea dict and the dimensions dict, neither of which appear to be documented anywhere.

It looks like foosel added it a year ago- but it isn't really documented.

(not filling out the issues template, it doesn't apply)

@GitIssueBot
Copy link

Hi @tedder,

It looks like there is some information missing from your bug report that will be needed in order to solve the problem. Read the Contribution Guidelines which will provide you with a template to fill out here so that your bug report is ready to be investigated (I promise I'll go away then too!).

If you did not intend to report a bug but wanted to request a feature or brain storm about some kind of development, please take special note of the title format to use as described in the Contribution Guidelines.

Please do not abuse the bug tracker as a support forum - if you have a question or otherwise need some kind of help or support refer to the Mailinglist or the G+ Community instead of here.

Also make sure you are at the right place - this is the bug tracker of the official version of OctoPrint, not the Raspberry Pi image OctoPi nor any unbundled third party OctoPrint plugins or unofficial versions. Make sure too that you have read through the Frequently Asked Questions and searched the existing tickets for your problem - try multiple search terms please.

I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2018-03-19 17:00 UTC) I'll close this ticket so it doesn't clutter the bug tracker. This is nothing personal, so please just be considerate and help the maintainers solve this problem quickly by following the guidelines linked above. Remember, the less time the devs have to spend running after information on tickets, the more time they have to actually solve problems and add awesome new features. Thank you!

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

@GitIssueBot GitIssueBot added the incomplete Issue template has not been fully filled out, no further processing until fixed label Mar 5, 2018
@foosel foosel changed the title No documentation for dimensions and printingarea in gcodeAnalysis data model [Request] Add documentation for dimensions and printingarea in gcodeAnalysis data model Mar 6, 2018
@GitIssueBot GitIssueBot added request Feature request and removed incomplete Issue template has not been fully filled out, no further processing until fixed labels Mar 6, 2018
@foosel
Copy link
Member

foosel commented Mar 6, 2018

I have my hands completely full with other things, so a PR to add the docs for this would be heartily welcome.

dforsi added a commit to dforsi/OctoPrint that referenced this issue Apr 2, 2018
Adds documentation for `dimensions` and `printingArea`; fixes `length`
and `volume`; adds two internal references.
Fixes OctoPrint#2463.
@foosel foosel closed this as completed in 6ec8b97 Jul 25, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants