Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Undrendered Timelapse not pulling fps from config #2621

Closed
gingerbreadassassin opened this issue May 2, 2018 · 2 comments
Closed
Labels
bug Issue describes a bug done Done but not yet released

Comments

@gingerbreadassassin
Copy link

What were you doing?

Trying to render an unrendered timelapse. I have offloaded this rendering to a more powerful server via a nfs share, roughly following this.

What did you expect to happen?

I expected the ffpmeg arguments to reflect my target fps setting (60)

What happened instead?

The "-framerate" parameter kept using the default value of 25

Did the same happen when running OctoPrint in safe mode?

I didn't try. The only plugins I have installed are fullscreen and octorant, and I think I found the problem anyway.

Version of OctoPrint

OctoPrint 1.3.8

Operating System running OctoPrint

OctoPi 0.15.0PE

Printer model & used firmware incl. version

Prusa i3 MK3

Browser and version of browser, operating system running browser

Chrome Version 65.0.3325.181 (Official Build) (64-bit)

Link to octoprint.log

octoprint.log

Link to contents of terminal tab or serial.log

Not an issue with the printer.

Link to contents of Javascript console in the browser

I don't believe this to be a browser issue.

Screenshot(s)/video(s) showing the problem:

This is unavailable, as I have "fixed" the problem, and the tmp folder has been cleared out. I'm clicking on the camera button under the "unrendered timelapses" section.

My fix was to edit this line so that fps=60. I added logging calls to troubleshoot, which show up with their line numbers in the octoprint.log file as warnings.

I believe this line should be passing the fps parameter to that function, but I'm not well versed in JS to try it.

I have read the FAQ.

@gingerbreadassassin
Copy link
Author

For what it's worth, the bitrate parameter functions as expected.

@GitIssueBot GitIssueBot added the triage This issue needs triage label May 2, 2018
@foosel foosel added bug Issue describes a bug and removed triage This issue needs triage labels May 3, 2018
@foosel foosel added the done Done but not yet released label May 3, 2018
@foosel foosel added this to the 1.3.9 milestone May 3, 2018
@foosel
Copy link
Member

foosel commented May 3, 2018

The backend code was at fault, not the frontend code. Fixed now on maintenance, soon devel and to be released with 1.3.9.

@foosel foosel closed this as completed in 13b85fb Jul 25, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue describes a bug done Done but not yet released
Projects
None yet
Development

No branches or pull requests

3 participants