Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Allow additional video formats to appear in the timelapse tab #2729

Closed
FormerLurker opened this issue Jul 12, 2018 · 4 comments
Closed
Labels
done Done but not yet released request Feature request
Milestone

Comments

@FormerLurker
Copy link

Is it possible to add support for the following formats within the timelapse file browser:
GIF
AVI
FLV
VOB
MPEG (might already work actually, need to test)

As you may have guessed, this is for Octolapse so that I can synchronize additional formats that are supported by the plugin. Currently I can copy the files into the timelapse folder, but they will not display and I cannot download them with a direct link.

Thanks!

What were you doing?

  1. ...
  2. ...
  3. ...

What did you expect to happen?

What happened instead?

Did the same happen when running OctoPrint in safe mode?

Version of OctoPrint

Operating System running OctoPrint

Printer model & used firmware incl. version

Browser and version of browser, operating system running browser

Link to octoprint.log

Link to contents of terminal tab or serial.log

Link to contents of Javascript console in the browser

Screenshot(s)/video(s) showing the problem:

I have read the FAQ.

@GitIssueBot GitIssueBot added request Feature request and removed request Feature request labels Jul 12, 2018
@koenkooi
Copy link
Contributor

I added some formats a while ago, have a look at #2409 to see the work involved.

FWIW, 'vob' is currently the default format, but using the 'mpg' suffix.

foosel added a commit that referenced this issue Jul 13, 2018
@foosel foosel added the done Done but not yet released label Jul 13, 2018
@foosel foosel added this to the 1.3.10 milestone Jul 13, 2018
@foosel
Copy link
Member

foosel commented Jul 13, 2018

I just added a new hook octoprint.timelapse.extensions that can be used to add additional supported extensions.

Available on maintenance, soon devel, to be released with 1.3.10.

@FormerLurker
Copy link
Author

@foosel, the hook worked as expected, excellent! 👍 This is a pretty big upgrade for Octolapse since the other video formats were too much of a bother to use before.

I did have to remove the _sendingLock from the _handle_ok method to test it out, but I was expecting that. Now to remove all of the warnings about which formats will sync from my settings and help files.

@foosel
Copy link
Member

foosel commented Dec 10, 2018

1.3.10 has been released.

@foosel foosel closed this as completed Dec 10, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
done Done but not yet released request Feature request
Projects
None yet
Development

No branches or pull requests

4 participants