Firmware info not reported to plugins if firmware autodetection is disabled

[foosel]

Problem

If firmware autodetection is disabled, firmware information gained from M115 will not be pushed to plugins anymore. It is fine to not evaluate that information actively for serial settings if detection is disabled, however it should still be pushed on the event bus and to plugins.

Solution

Slight logic change. Already fixed in 831edf2.

Additional notes

Not a regression, but considering that it negatively impacts the printer safety plugin that relies on firmware info it'll go into 1.4.0 regardless.

[GitIssueBot]

This issue has been mentioned on OctoPrint Community Forum. There might be relevant details there:

https://community.octoprint.org/t/new-release-candidate-1-4-0rc6/16502/1

[foosel]

1.4.0rc6 is out