Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCode viewer options non-functional #35

Closed
splitbrain opened this issue Feb 4, 2013 · 6 comments

Comments

Projects
None yet
6 participants
@splitbrain
Copy link
Contributor

commented Feb 4, 2013

The new GCode viewer is absolutely awesome! However, the options below the viewer seem to do nothing for me. I assume they should unfold some settings?

I don't get any JS errors though. Tested on Chromium 24

@Lenbok

This comment has been minimized.

Copy link

commented Feb 5, 2013

I assume they are hangovers from when the gcode viewer was a standalone app.

The non-working options should be removed/hidden.

@hudbrog

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2013

Actually, these should work.. and for me they do work.. well, most of the time. I'll take a look later to see where the problem is.

@lthomas987

This comment has been minimized.

Copy link

commented Mar 10, 2013

I have observed this as well. Tonight I discovered that the gcode viewer options work under Chrome Version 25.0.1364.160 but not under Firefox 19.0.2. These are both the current version on OSX right now. I haven't checked Safari and can't right now as I am staring at the Server is offline dialog waiting for my bed to heat up.

foosel added a commit that referenced this issue Mar 10, 2013

Temporary workaround for the gcode viewer options not cooperating unt…
…il those are integrated a bit more.

Targets #35.
@foosel

This comment has been minimized.

Copy link
Owner

commented Mar 10, 2013

@lthomas987 Do you always get the offline dialog during heatup? That shouldn't happen actually... If so could you open another ticket for this, maybe with some additional info re printer model, communication log etc?

Regarding the controls not working, I'm trying to figure out a way to move most of these into the settings actually. I've now simply expanded them all for the time being, until I manage to do so. I hope this works, I've yet to successfully reproduce the issue when I try to hunt it down.

@imitation

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2013

If you manage to switch to the gcoder viewer's tab fast enough after a refresh and open some of the sections, they keep working for a while.
FF19

foosel added a commit that referenced this issue Jan 5, 2014

More work on the GCode viewer
- confirmation dialog when trying to visualize large files (different threshold for mobile and "regular" devices, configurable of course, although only via config file right now) - should also help a bit with issues leading to #215
 - proper clearing of the viewer area when reconnecting to the backend (e.g. after server restart)

 Also all of this plus previous commits closes #35
@foosel

This comment has been minimized.

Copy link
Owner

commented Jan 5, 2014

Closed in devel (because the options where completely changed there...)

@foosel foosel closed this Jan 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.