Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printer profiles do not save extruder offsets (for first extruder) #677

Closed
imitation opened this issue Dec 11, 2014 · 14 comments

Comments

Projects
None yet
3 participants
@imitation
Copy link
Contributor

commented Dec 11, 2014

Printer profiles do not save extruder offsets, they always reset to 0.
log: http://pastebin.com/S8S3vMRE
Version: 1.2.0-dev-340-g85a567b (devel branch) [newest as of post]

Do I love cookies? I don't know anymore. Christmas started too early this year.

foosel added a commit that referenced this issue Dec 19, 2014

@foosel

This comment has been minimized.

Copy link
Owner

commented Dec 19, 2014

Two bugs for the price of one m(

@foosel foosel closed this Dec 19, 2014

@imitation

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2014

Still getting the same behavior (Version: 1.2.0-dev-359-g256c2df (devel branch))
Fresh log: http://pastebin.com/4SRmQf9Z

Firefox also spits out a few warnings like these:
Leerer String an getElementById() übergeben. jquery.min.js:4

@foosel

This comment has been minimized.

Copy link
Owner

commented Dec 21, 2014

Can you provide the stack trace from your javascript console? (Screenshot is ok too)

Just tried it, works flawlessly on my end, so this might become a bit ugly to get to the root of... (I hate it when I can't reproduce the issues myself, makes debugging bloody hard)

@foosel foosel reopened this Dec 21, 2014

@imitation imitation changed the title Printer profiles do not save extruder offsets Printer profiles do not save extruder offsets (for first extruder) Dec 29, 2014

@imitation

This comment has been minimized.

Copy link
Contributor Author

commented Dec 29, 2014

More details: Only the first extruder slot is affected, subsequent ones work perfectly.

I didn't manage to capture a meaningful stack trace, though. Gina, if you want to poke around yourself, hit me up on Hangouts and i'll give you TeamViewer access to one of my computers.

@foosel

This comment has been minimized.

Copy link
Owner

commented Dec 29, 2014

The first one is supposed to be the reference value and hence acts as origin, with the other extruders relative to it (I'm fairly sure I actually wrote this somewhere, but can't find it myself now anymore, meh). But since this is the case it shouldn't in fact be editable fields for that and a little footnote, so I'll leave this open until I've done this.

@imitation

This comment has been minimized.

Copy link
Contributor Author

commented Dec 29, 2014

I used to use the extruder offset to compensate for the fact that my
printbed (150x150mm) is not left-aligned (but centered) on the travel of
the X-axis (440mm). Of course, that is a somewhat specific use case and i
wouldn't disagree if that functionality got stripped out. But, like this,
does it allow for configurations where the origin (position 0,0) is
centered on the bed? Or for configs where the first extruder/hotend can
physically pass over the left edge of the build space to make the entire
space usable for the other extruders/hotends?

@foosel

This comment has been minimized.

Copy link
Owner

commented Dec 29, 2014

In that case I guess it would make more sense that I decouple the "print bed is circular" from the "origin is at printbed's center" option, maybe even add a new "origin offset" or something (relative to the center for circular beds and to the lower left corner for rectangular beds).

I have been meaning to do this anyhow since I learned (only a couple weeks back actually!) that Mendel90s seem to ship with that. I so far had the impression that rectangular print beds usually have a lower-left approach to the whole origin thing ;)

Opinions? :)

@imitation

This comment has been minimized.

Copy link
Contributor Author

commented Dec 29, 2014

Afaik, nophead does ship his M90 kits with the origin at the center point, since it makes the gcode portable between printers of different sizes and geometries. Whether or not the same gcode really should be used on different machines is a different topic, but there are definitely cartesian printers configured like this.
Both the firmware and the slicer (depending on who handles offsets) always treats extruder 0 as a zero-offset one. So, in the simplest case, the firmware would be configured to have the minimum positions at some negative value to keep the front left corner of the bed (or of the usable build envelope) at 0,0 at all times. No need for additional offsets in OctoPrint in that case. Cura only supports this configuration, while Slic3r lets you set the front left corner to an arbitrary point.

If you're going to decouple those options anyways, i'd agree with the trifecta of "Origin is at the front-left corner", "Origin is centered" and "Origin is in some other spot. Please specify:..."

@nophead

This comment has been minimized.

Copy link
Contributor

commented Dec 30, 2014

I have been running OctoPrint on mMendel90s with the bed in the centre and
never noticed any problem. The gcode is centred correctly in the gcode
view.

I also can't find any setting for bed dimensions or whether it is circular.
Where are those?

On 29 December 2014 at 19:55, Thomas Sanladerer notifications@github.com
wrote:

Afaik, nophead does ship his M90 kits with the origin at the center point,
since it makes the gcode portable between printers of different sizes and
geometries. Whether or not the same gcode really should be used on
different machines is a different topic, but there are definitely cartesian
printers configured like this.
Both the firmware and the slicer (depending on who handles offsets) always
treats extruder 0 as a zero-offset one. So, in the simplest case, the
firmware would be configured to have the minimum positions at some negative
value to keep the front left corner of the bed (or of the usable build
envelope) at 0,0 at all times. No need for additional offsets in OctoPrint
in that case. Cura only supports this configuration, while Slic3r lets you
set the front left corner to an arbitrary point.

If you're going to decouple those options anyways, i'd agree with the
trifecta of "Origin is at the front-left corner", "Origin is centered" and
"Origin is in some other spot. Please specify:..."

Reply to this email directly or view it on GitHub
#677 (comment).

@foosel

This comment has been minimized.

Copy link
Owner

commented Jan 12, 2015

@nophead on master there's a checkbox under "Printer Parameters" in the Settings. On devel it's now part of the Printer Profiles (also available through the Settings):

image

I'm a bit puzzled actually that the GCODE viewer doesn't show the previews centered on (0,0) for you.

@nophead

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2015

I don't have that tickbox, must be too old a version. Version: 1.1.0 (master branch)

TBH the gcode preview hardly ever does anything. When it does show up the print is in the middle of the grid, my gcode is always centred on 0,0.

@foosel

This comment has been minimized.

Copy link
Owner

commented Jan 22, 2015

FYI, the "additional option to set the print bed origin" is now tracked in #682.

This one is still left open until I've either removed the offsets for single extruder printers or made the first extruder offset fields read-only (probably the former though)

foosel added a commit that referenced this issue May 5, 2015

Better extruder/nozzle offset editing in the printer profiles
If only one tool is configured, the profile dialog now won't show the offset configuration. If more than one extruder is configured offset configuration for anything but the first tool (which acts as reference for the relative offsets of the others) will be shown.

Closes #677
@foosel

This comment has been minimized.

Copy link
Owner

commented May 5, 2015

Fixed now. Offset for first tool (which is the reference) is now not displayed anymore, offset configuration in general only shows up if more than one extruder is configured, starting with the offset of T1

@foosel foosel closed this May 5, 2015

@foosel

This comment has been minimized.

Copy link
Owner

commented May 5, 2015

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.