Bugfix for Invalid cross-device link on Linux when /tmp is on another fs #717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. There are fix for #710 and #716
When octoprint going to move a file from one directory to another on linux, if directories is located on different filesystems, os.rename wouldn't work, raising error "OSError: [Errno 18] Invalid cross-device link". In that pull request it is fixed with changing os.rename into shutil.move
Another effect of changing: shutil.move is high-level operation, which uses os.rename if it is acceptable, so maybe win32-specific code isn't needed with shutil (investigations still needed though).