Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[Bug] /devel babel refresh in setup.py does not work #726
Comments
This comment has been minimized.
This comment has been minimized.
|
Hi @derpicknicker1, It looks like there is some information missing from your ticket that will be needed in order to process it properly. Please take a look at the Contribution Guidelines and the page How to file a bug report on the project wiki, which will tell you exactly what your ticket has to contain in order to be processable. If you did not intend to report a bug, please take special note of the title format to use as described in the Contribution Guidelines. I'm marking this one now as needing some more information. Please understand that if you do not provide that information within the next two weeks (until 2015-01-31 18:20) I'll close this ticket so it doesn't clutter the bug tracker. Best regards, PS: I'm just an automated script, not a human being. |
This comment has been minimized.
This comment has been minimized.
|
Version: Version: 1.2.0-dev-405-gf52afb8-dirty (devel branch) Printer: Replicape Firmware: redeem Terminal Log: N/A octoprint.log: N/A I love cookies!!! |
Thanks to @derpicknicker1 for report and suggested fix. Closes #726
This comment has been minimized.
This comment has been minimized.
|
Fixed in And big thanks again for that full blown analysis and suggested fix. Have you thought about actually turning stuff like this into pull requests so that you get properly credited in the commit log (trying to do my best here with mentioning). |
While i was trying to refresh the translation files i found some issues in the automated refresh process.
The command to update the cataloges gets babel.cfg as input file. This should be the messages.pot file. so change Line 197 in setup.py to
Now refresh works and *.po files are updated correctly. If you did a babel_refresh before, you have to revert the message.po files to the originals from branch. By using babel.cfg for updating the *.po files they get messed up. For example you can use the following command.
An other issue is, that the plugins directory will not be searched for messages in *.js and *.jinja2 files. You have to add a few lines to babel.cfg to get them included.
Now
install setup.py babel_refreshshould work fine.I am using Version: 1.2.0-dev-405-gf52afb8-dirty (devel branch)
Logfiles N/A, not needed.