Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brainstorming] High resolution support for gcode viewer #837

Closed
lucas-clemente opened this issue Apr 3, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@lucas-clemente
Copy link
Contributor

commented Apr 3, 2015

This isn't a high priority, but the gcode viewer currently doesn't seem to support high-resolution (retina) screens.

I will try to look into it over the next few days and see whether it's easy to implement (e.g. using window.devicePixelRatio to scale the canvas).

To please your bot (and since I wan't allowed to reopen #836):

What were you doing?
Using octoprint.

What did you expect to happen?
Retina gcode viewer.

What happened instead?
Non-retina gcode viewer.

Branch & Commit or Version of OctoPrint:

Printer model & used firmware incl. version
(if applicable - always include if unsure):

Browser and Version of Browser, Operating
System running Browser (if applicable - always
include if unsure):

Link to octoprint.log on gist.github.com or pastebin.com:

Link to contents of terminal tab or serial.log on
gist.github.com or pastebin.com (if applicable - always
include if unsure or reporting communication issues):

Link to contents of Javascript console in the browser
on gist.github.com or pastebin.com or alternatively a
screenshot (if applicable - always include if unsure
or reporting UI issues):

Screenshot(s) showing the problem (if applicable - always
include if unsure or reporting UI issues):

I have read the FAQ.

@foosel

This comment has been minimized.

Copy link
Owner

commented Apr 13, 2015

The highest resolution I have available for testing here is Full HD, so I can't help here I fear other than by hinting at where to look for stuff.

@foosel

This comment has been minimized.

Copy link
Owner

commented May 5, 2015

Fixed by your own PR, thank you! :)

@foosel foosel closed this May 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.