Fix for #1001 connection tab not unfolding #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defer collapsing the connection element until the whole wrapper part is visible (it's hidden for non-admins).
| if (self.isOperational() && connectionTab.hasClass("in")) { | ||
| // connection just got established, close connection tab for now | ||
| connectionTab.collapse("hide"); | ||
| } else if (!connectionTab.hasClass("in")) { |
There was a problem hiding this comment.
I also changed this line when I moved it. I think there's another bug here. At least, this isn't idempotent, because if the first isOperational is true but the tab has already been hidden, the else if doesn't check the isOperational again and will just show the tab incorrectly.
foosel
added a commit
that referenced
this pull request
Jul 30, 2015
Fix for #1001 connection tab not unfolding
|
Big thanks for that. I noticed that too from to time, but could never point my finger on what was causing it and of course was unable to reproduce it whenever I set out to hunt it down. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer collapsing the connection element until the whole wrapper part is
visible (it's hidden for non-admins).