Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1001 connection tab not unfolding #1002

Merged
merged 1 commit into from Jul 30, 2015

Conversation

Projects
None yet
2 participants
@markwal
Copy link
Collaborator

commented Jul 30, 2015

Defer collapsing the connection element until the whole wrapper part is
visible (it's hidden for non-admins).

Fix for #1001 connection tab not unfolding
Defer collapsing the connection element until the whole wrapper part is
visible (it's hidden for non-admins).
if (self.isOperational() && connectionTab.hasClass("in")) {
// connection just got established, close connection tab for now
connectionTab.collapse("hide");
} else if (!connectionTab.hasClass("in")) {

This comment has been minimized.

Copy link
@markwal

markwal Jul 30, 2015

Author Collaborator

I also changed this line when I moved it. I think there's another bug here. At least, this isn't idempotent, because if the first isOperational is true but the tab has already been hidden, the else if doesn't check the isOperational again and will just show the tab incorrectly.

foosel added a commit that referenced this pull request Jul 30, 2015

Merge pull request #1002 from markwal/connectiontabunfold1001
Fix for #1001 connection tab not unfolding

@foosel foosel merged commit d773b9d into foosel:devel Jul 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@foosel

This comment has been minimized.

Copy link
Owner

commented Jul 30, 2015

Big thanks for that. I noticed that too from to time, but could never point my finger on what was causing it and of course was unable to reproduce it whenever I set out to hunt it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.