Fix checks with os.path.realpath() for systems with symlinked paths #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for spotting this. Bug ticket is not necessary, I'll put that into the CHANGELOG with reference to the PR. Want me to also add you to the |
|
I've added my name to the authors file myself. Cheers! |
foosel
added a commit
that referenced
this pull request
Sep 8, 2015
Fix checks with os.path.realpath() for systems with symlinked paths
|
Perfect, thanks again! |
5 tasks
|
@foosel, would it be possible to merge this PR into the upcoming maintenance release? I'm working on a new version of the OctoPrint package for Synology NASes. Basing that package on a tagged release would make that a lot easier. Thanks in advance! |
|
@markbastiaans Just did. Planning on releasing 1.2.8 monday or tuesday (if nothing horrible happens again...) |
|
Thanks @foosel! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on getting a recent version of Octoprint (1.2.6) packaged for Synology NASes in SynoCommunity/spksrc. I've gotten it to work after some tinkering, but it needed two trivial fixes to work with Synology's habit of putting packages in a symlinked location. Specifically, two checks using
os.path.realpath()fail on Synology's OS while they shouldn't be.I've not filed a bug report for this yet, let me know if I should. I've tested the fix on Synology only but I think the fix is so trivial that it won't will negatively impact other platforms.