Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checks with os.path.realpath() for systems with symlinked paths #1051

Merged
merged 2 commits into from Sep 8, 2015

Conversation

Projects
None yet
2 participants
@markbastiaans
Copy link

commented Sep 8, 2015

I'm working on getting a recent version of Octoprint (1.2.6) packaged for Synology NASes in SynoCommunity/spksrc. I've gotten it to work after some tinkering, but it needed two trivial fixes to work with Synology's habit of putting packages in a symlinked location. Specifically, two checks using os.path.realpath() fail on Synology's OS while they shouldn't be.

I've not filed a bug report for this yet, let me know if I should. I've tested the fix on Synology only but I think the fix is so trivial that it won't will negatively impact other platforms.

@foosel

This comment has been minimized.

Copy link
Owner

commented Sep 8, 2015

Thanks for spotting this. Bug ticket is not necessary, I'll put that into the CHANGELOG with reference to the PR. Want me to also add you to the AUTHORS.md file while at it or do it yourself? :)

Mark Bastiaans
@markbastiaans

This comment has been minimized.

Copy link
Author

commented Sep 8, 2015

I've added my name to the authors file myself. Cheers!

foosel added a commit that referenced this pull request Sep 8, 2015

Merge pull request #1051 from markbastiaans/fix-realpath-checks
Fix checks with os.path.realpath() for systems with symlinked paths

@foosel foosel merged commit 0346002 into foosel:devel Sep 8, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@foosel

This comment has been minimized.

Copy link
Owner

commented Sep 8, 2015

Perfect, thanks again!

@markbastiaans markbastiaans deleted the markbastiaans:fix-realpath-checks branch Sep 8, 2015

@markbastiaans markbastiaans referenced this pull request Sep 8, 2015

Merged

New version of OctoPrint SPK and add CuraEngine SPK #1837

5 of 5 tasks complete
@markbastiaans

This comment has been minimized.

Copy link
Author

commented Dec 4, 2015

@foosel, would it be possible to merge this PR into the upcoming maintenance release? I'm working on a new version of the OctoPrint package for Synology NASes. Basing that package on a tagged release would make that a lot easier.

Thanks in advance!

@foosel

This comment has been minimized.

Copy link
Owner

commented Dec 4, 2015

@markbastiaans Just did. Planning on releasing 1.2.8 monday or tuesday (if nothing horrible happens again...)

@markbastiaans

This comment has been minimized.

Copy link
Author

commented Dec 7, 2015

Thanks @foosel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.