Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for post roll for timed timelapse to duplicate last frame #1553

Merged
merged 1 commit into from Nov 22, 2016

Conversation

Projects
None yet
2 participants
@dattas
Copy link
Contributor

commented Oct 21, 2016

What does this PR do and why is it necessary?

Adds ability to simply repeat the last frame of capture instead of capturing several minutes (or hours) of footage after print is completed.

How was it tested? How can it be tested by the reviewer?

Tested on 3 octoprint instances with 3 different cameras and some different plugins as well. It can be tested via going to timelapse, unchecking the new checkbox (ensuring there is a postroll interval) and saving, then running a print.

Any background context you want to provide?

What are the relevant tickets if any?

#1422

Screenshots (if appropriate)

Further notes

Add option to repeat last captured frame instead of capturing new fra…
…mes for the end of a timelapse. Defaults to current behavior (capturing new frames for the time after). Implements #1422
@foosel

This comment has been minimized.

Copy link
Owner

commented Oct 26, 2016

Hmm, what I don't like here is the code duplication going on. ZTimelapse and TimedTimelapse with non captured post roll now basically contain the exact same code in process_postroll. That screams for extracting that into a custom "copying_postroll" (or better named) method on the Timelapse parent class and then just calling that from the child classes were appropriate.

Could you modify your pr accordingly? No problem if not, would just mean merging would have to wait until I'm back on my feet (which I'm currently not).

Cheers!

@foosel foosel merged commit 7e2382f into foosel:devel Nov 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.