Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in strings and comments #2044

Merged
merged 1 commit into from Sep 29, 2017
Merged

Conversation

dforsi
Copy link
Contributor

@dforsi dforsi commented Jul 30, 2017

Those typos were found with codespell which is available from
https://github.com/lucasdemarchi/codespell.git

Thank you for your interest into contributing to OctoPrint, it's
highly appreciated!

Please make sure you have read the "guidelines for contributing" as
linked just above this form, there's a section on Pull Requests in there
as well that contains important information.

As a summary, please make sure you have ticked all points on this
checklist:

  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's devel branch, or maintenance if it's
    a bug fix for an issue present in the current stable version (no PRs
    against master or anything else)
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance or devel please),
    e.g. dev/my_new_feature
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase your PR if necessary!
  • Your changes follow the existing coding style
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated with
    lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke
  • You have added yourself to the AUTHORS.md file :)

Feel free to delete all this help text, then describe
your PR further. You may use the template provided below to do that.
The more details the better!


What does this PR do and why is it necessary?

This PR fixes some misstypings in user-visible messages, in strings that go to log files and in comments.

How was it tested? How can it be tested by the reviewer?

Tested executing the unit tests and running the server.
Visual inspection of the colored diff here in github shows that only single words were changed.

Any background context you want to provide?

While these are trivial mistypings, having them fixed means that searching through the source will not miss these words and future runs of codespell are more likely to show if anything has changed

What are the relevant tickets if any?

Screenshots (if appropriate)

Further notes

I am submitting only changes to strings excluding vendor source files (eg. jQuery) and I did not change the following lines because "managable" is an object property (just let me know if you think it makes sense to replace all these occurrences with the word "manageable"):

src/octoprint/plugins/pluginmanager/__init__.py:463: managable  ==> manageable, manageably
src/octoprint/plugins/pluginmanager/__init__.py:464: managable  ==> manageable, manageably
src/octoprint/plugins/pluginmanager/__init__.py:963: managable  ==> manageable, manageably
src/octoprint/plugins/pluginmanager/__init__.py:963: managable  ==> manageable, manageably
src/octoprint/plugins/pluginmanager/templates/pluginmanager_settings.jinja2:50: managable  ==> manageable, manageably
src/octoprint/plugins/pluginmanager/static/js/pluginmanager.js:231: managable  ==> manageable, manageably
src/octoprint/plugin/core.py:145: managable  ==> manageable, manageably
src/octoprint/plugin/core.py:589: managable  ==> manageable, manageably
src/octoprint/plugin/core.py:651: managable  ==> manageable, manageably

Those typos were found with codespell which is available from
https://github.com/lucasdemarchi/codespell.git
@foosel foosel merged commit 1212662 into OctoPrint:maintenance Sep 29, 2017
@foosel
Copy link
Member

foosel commented Sep 29, 2017

Thank you! And sorry for the delay in merging this, first I was on vacation, then just when I was starting to catch up on the backlog I got sick (and I'm still recovering from that) :/

For now I'd say let's leave the manageable issue as is, exactly due to the reason you already stated. Backwards compatibility and all that. At least this won't be the first time such a misspelling makes it into an API ;)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants