Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance Issue #2077 #2123

Merged
merged 1 commit into from Sep 29, 2017
Merged

Conversation

galamdring
Copy link
Contributor

Thank you for your interest into contributing to OctoPrint, it's
highly appreciated!

Please make sure you have read the "guidelines for contributing" as
linked just above this form, there's a section on Pull Requests in there
as well that contains important information.

As a summary, please make sure you have ticked all points on this
checklist:

  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's devel branch, or maintenance if it's
    a bug fix for an issue present in the current stable version (no PRs
    against master or anything else)
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance or devel please),
    e.g. dev/my_new_feature
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase your PR if necessary!
  • Your changes follow the existing coding style
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated with
    lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke
  • You have added yourself to the AUTHORS.md file :)

Feel free to delete all this help text, then describe
your PR further. You may use the template provided below to do that.
The more details the better!


What does this PR do and why is it necessary?

Corrects Issue #2077 caused by the temperature graph only watching Tool0 when Shared Nozzle is enabled, but Comm assigned the temperature it gets to the current tool.

How was it tested? How can it be tested by the reviewer?

     -- Tested with Shared nozzle on, and off. Temp(actual and target) were assigned to Tool0 correctly when SharedNozzle was enabled, and only to the current tool when it was not. 
     -- I was unable to test with multiple temps coming from the firmware, but with the behavior I witnessed, I feel confident that it does not break that functionality.

Any background context you want to provide?

What are the relevant tickets if any?

Issue #2077

Screenshots (if appropriate)

Further notes

@foosel foosel merged commit 791f045 into OctoPrint:maintenance Sep 29, 2017
foosel added a commit that referenced this pull request Sep 29, 2017
@foosel
Copy link
Member

foosel commented Sep 29, 2017

Thank you! 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants