Add possible print disruption warning to shutdown dialog #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
Add an extra warning text to the shutdown dialog about potentially disrupting
any ongoing prints, including those running off an SD card attached to
the printer, in case certain control boards are sensitive to random
serial activity causing them to be reset.
Also added a bold tag to the action being performed (shutdown vs restart) to draw a users eye to that section to indicate this text may be worth reading.
How was it tested? How can it be tested by the reviewer?
Access the system shutdown / restart menu, additionally activate or de-activate a plugin that requires a restart, observe the shutdown dialog now contains the new warning.
What are the relevant tickets if any?
As per request: #2131
Screenshots (if appropriate)
Further notes
I think it's worth mentioning why certain boards happen to reset on serial activity, but perhaps not in this dialog box. Maybe that's best left to the FAQ / wiki page?
Same as before, but based off maintenance this time (I hope)