Add print interruption warning to auto update dialog #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay! 👍 |
|
note/question Should the h5 be changed to a bold? or just removed entirely? It's been driving me insane ever since the discussion. I thought about the big scary warning being the next "section", first section being release notes, but since the first "section" doesn't have a bold heading, should I just remove the bold/heading all together and make it normal text? Or do you want to just take care of it on your end and I should stop obsessing over it? |
|
I'll take care of it, no need to obsess ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
Adds a warning to the auto updater dialog about possibly resetting your printer. This typically only applies when using octoprint to monitor a printer that is printing off an SD card, which was initiated via the LCD panel in which case OctoPrint has no way of knowing the printer is busy and therefore won't automatically block the installation of updates.
How was it tested? How can it be tested by the reviewer?
Install an old version of a plugin or octoprint, allow it to notify you of an update, observe the new dialog box warns about a possible reset
Any background context you want to provide?
Fills in a missing piece of a feature request that was missed on the first PR
What are the relevant tickets if any?
#2131
Screenshots (if appropriate)
Further notes