Handle non-[existent/functioning] tools #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why is it necessary?
Resolves an issue where sending M104/M109 specifying a non-existent tool(T) will result in the actual temp being recorded as None.
Updates the temperature data for invalid tools so that the UI sets the target temperature back to off.
How was it tested? How can it be tested by the reviewer?
I've only tested this on a printer with one tool. Would be great if someone with multiple could test prior to merge.
M104 T1 S100to a printer with only one tool. Temperature data should no longer include the non-[existent/functioning] tool.NOTE: Temperature may still set for T0 if there is only one tool defined in the firmware.
Any background context you want to provide?
What are the relevant tickets if any?
PSUControl#68
Screenshots (if appropriate)
Further notes