Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always run the GCodeAnalyser, even if the slicer provided analysis #2723

Merged
merged 1 commit into from Jul 18, 2018

Conversation

eyal0
Copy link
Contributor

@eyal0 eyal0 commented Jul 10, 2018

The analysis from the Slicer or other sources is sent to the GCodeAnalyser, which can use it or ignore it.

This fixes #2445 (comment)

  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's devel branch, or maintenance if it's
    a bug fix for an issue present in the current stable version (no PRs
    against master or anything else please)
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of master, maintenance or devel please),
    e.g. dev/my_new_feature or fix/my_bugfix
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase and squash your PR
    if necessary!
  • Your changes follow the existing coding style
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated with
    lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke
  • You have added yourself to the AUTHORS.md file :)

What does this PR do and why is it necessary?

Run GCodeAnalyser on files sliced on RPi, in addition to those uploaded.

How was it tested? How can it be tested by the reviewer?

Without this patch:

  1. Run OctoPrint
  2. Upload a file.
  3. Observe that the file is analyzed (logs will show Starting analysis of <filename>)
  4. Slice a file using a built-in slicer, like cura.
  5. No logs about analyzing are printing.

With this patch:

  1. Run OctoPrint
  2. Upload a file.
  3. Observe that the file is analyzed (logs will show Starting analysis of <filename>)
  4. Slice a file using a built-in slicer, like cura.
  5. Observe that the file is analyzed (logs will show Starting analysis of <filename>)

Any background context you want to provide?

This is important for the new analysis hook.
#2445 (comment)

What are the relevant tickets if any?

#2445

The analysis from the Slicer or other sources is sent to the GCodeAnalyser, which can use it or ignore it.

This fixes OctoPrint#2445 (comment)
This fixes eyal0/OctoPrint-PrintTimeGenius#13
eyal0 added a commit to eyal0/OctoPrint-PrintTimeGenius that referenced this pull request Jul 11, 2018
@foosel foosel merged commit 40b5c27 into OctoPrint:maintenance Jul 18, 2018
@foosel foosel added this to the 1.3.10 milestone Oct 31, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants