Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent installing on python 3. #2882

Closed
wants to merge 2 commits into from
Closed

Prevent installing on python 3. #2882

wants to merge 2 commits into from

Conversation

fake-name
Copy link
Contributor

@fake-name fake-name commented Nov 11, 2018 •
edited

Right now, it installs, and then just explodes at runtime.

Fixes #2881

@fake-name
Prevent installing on python 3.
4a36ddb 
Right now, it installs, and then just explodes runtime.
@fake-name
Handle unsupported version at runtime.
2f20f2d 
If you have an ancient setuptools, 4a36ddb
won't successfully prevent installing. These changes will at least give a sane error, 
rather then  just barfing on random syntax errors due to the `unicode` type not
being present in py3k.
@foosel
Copy link
Member

foosel commented Nov 12, 2018

The first of your commits has already been covered in 909dd55 (which is part of 1.3.10rc1 but hasn't yet been merged to devel since I encountered some merge issues which I still have to sort out). To work around the issue with ancient setuptools - could you redo this PR against the maintenance branch with only the runtime check? Thanks :)

@foosel foosel added the needs some work There are some things to do before this PR can be merged label Nov 12, 2018
@ByReaL
Copy link
Contributor

ByReaL commented Dec 2, 2018

i'll try make it work with python3 as i have time, i would like to still be able to install it on python3,
maybe a warning should be good or a way to force the install on python3

@foosel
Copy link
Member

foosel commented Dec 3, 2018

devel branch is going to get this restriction lifted again for this very reason.

@foosel foosel added this to the 1.3.11 milestone Dec 13, 2018
@foosel
Copy link
Member

foosel commented Dec 19, 2018

I've cherry picked the second commit on maintenance as 52c7321 (and commented out the changes on devel in 5b4f4e3 while we work towards Py3 support there).

Closing this manually since Github doesn't detect cherry picks.

@foosel foosel closed this Dec 19, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
needs some work There are some things to do before this PR can be merged
Projects
None yet
Milestone
1.3.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fake-name @foosel @ByReaL