Confirm custom command Req #532 #589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork
Fix error where API state is requested and printer is offline
Basic travis config
- Refactored drawGrid into two functions drawRectangularGrid and drawCircularGrid - Made sure grid for circular beds always "starts" at (0,0) so that e.g. for a radius of 105mm the center of the bed will be on the grid lines - Made center on circular bed be better visible by making origin lines thicker - Made initial focus on bed center properly
…le at it also fixed OctoPrint#365
… file upload response
Should help debugging issue OctoPrint#425 and any future problems in that area.
Should keep rendering of timelapse from breaking if only a couple of images couldn't be captured due to whatever reason. Suggested by @midopple in OctoPrint#344
…called "offset" not "offsets" Compare OctoPrint#444
Negative durations, especially for print time left, might arise if estimation is estimating less than current print time. So we just erase that margin of error in the UI. Closes OctoPrint#435
… directly when file list changes
…uthenticated users/apikey only)
…n as first helpers
- Additional zeroconf services may now be added via config - Exposed zeroconf_register method as helper for plugins - Vendor specifics may be added to service registrations via config
netconnectd now regularly pings hostname it got from backend (defaults to <systemname>.local) while switching to wifi from ap mode and reloads page to that if host comes up. This requires the browser the client is currently running in to be able to resolve local domains as broadcasted via avahi. Windows systems will need to install the Bonjour for Windows client for this to work.
…discovered Plugins may be able to use this method for final setups before the implementations and hooks are evaluated, e.g. for adjusting their offered functionality based on what other plugins are available.
Javascript is not python...
…iewer slides stop working
Merged PR OctoPrint#577 - Allow plugins that hook into comms Establishes basics for alternative version to implement OctoPrint#324
Conflicts: CHANGELOG.md
Conflicts: src/octoprint/server/__init__.py
Temporarily broke event registration by frontend, this should fix it again.
…, iterate over registered view models instead
…we need a different handler for the updates to work
Syntax (and code) similar to System Command confirm. First commit, please be gentle.
|
Ok I pulled this against master, sorry needed to go against devel of course... I don't know how to change it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the code so that custom commands can also take a field "confirm": "Confirmation text" before being executed. Req #532 asked for it and I needed it too, so I coded it.
First commit, hope it merges well and I did the guidelines correct.