Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added QR code with API key on Settings dialog #637

Merged
merged 1 commit into from Nov 8, 2014

Conversation

Projects
None yet
2 participants
@imrahil
Copy link
Contributor

commented Nov 5, 2014

basic stuff... maybe need more polishing (I'm noob with LESS so I added CSS in HTML :) )
qr_code

onsubmit="return false;"

I added this to prevent modal closing when enter key is pressed

@foosel

This comment has been minimized.

Copy link
Owner

commented Nov 8, 2014

@imrahil What license does that qrcode library have you added there? I also need the link to that.

@imrahil

This comment has been minimized.

Copy link
Contributor Author

commented Nov 8, 2014

@foosel foosel merged commit 25cfed9 into foosel:devel Nov 8, 2014

@foosel

This comment has been minimized.

Copy link
Owner

commented Nov 8, 2014

I switched to another library (jquery plugin) and turned the whole qrcode generation into a knockout binding, so now it's reusable too (e.g. for the user api keys - which I would have qrcoded too while at it, but the value binding refused to update)

@imrahil imrahil deleted the imrahil:feature_qr_code branch Nov 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.