Added QR code with API key on Settings dialog #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imrahil What license does that qrcode library have you added there? I also need the link to that. |
|
Licence MIT |
|
I switched to another library (jquery plugin) and turned the whole qrcode generation into a knockout binding, so now it's reusable too (e.g. for the user api keys - which I would have qrcoded too while at it, but the value binding refused to update) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic stuff... maybe need more polishing (I'm noob with LESS so I added CSS in HTML :) )
I added this to prevent modal closing when enter key is pressed