Stop sockjs from multiplying on reconnect

[markwal]

Have you ever noticed when developing that every time you stop and start
the server, the terminal window gets an extra duplicate line for every
reconnect attempt? Well, it's because (I think) "delete" in javascript
just removes the indicated name from the namespace, it doesn't actually
free up an object. Those zombie objects are still there and wake up (for
some transports) on reconnect. Might be different in SockJS v1 or later.

Anyway, this fixes it for me in Chrome.

[foosel]

Magic number? Where does that come from?

[markwal]

Sockjs sources. They used a magic number too, no define or docs that I could find. It means from a direct call to close in v0.3.4.

Probably we should define our own. It'll give back whatever we pass to close. But still weird since sockjs could still stomp on it with the same value used internally.

[foosel]

Let me just say "ewww"

[nophead]

Yes I have seen the terminal lines get duplicated, then triplicated, etc.
Not developing though, just using OctopPrint.

On 11 May 2015 at 03:03, Mark Walker notifications@github.com wrote:

Have you ever noticed when developing that every time you stop and start
the server, the terminal window gets an extra duplicate line for every
reconnect attempt? Well, it's because (I think) "delete" in javascript
just removes the indicated name from the namespace, it doesn't actually
free up an object. Those zombie objects are still there and wake up (for
some transports) on reconnect. Might be different in SockJS v1 or later.

Anyway, this fixes it for me in Chrome.

You can view, comment on, or merge this pull request online at:

#888
Commit Summary

• Stop sockjs from multiplying on reconnect

File Changes

• M src/octoprint/static/js/app/dataupdater.js
  https://github.com/foosel/OctoPrint/pull/888/files#diff-0 (7)

Patch Links:

• https://github.com/foosel/OctoPrint/pull/888.patch
• https://github.com/foosel/OctoPrint/pull/888.diff

Reply to this email directly or view it on GitHub
#888.

[markwal]

OK, https://developer.mozilla.org/en-US/docs/Web/API/CloseEvent defines it as CLOSE_NORMAL, but sockjs just says 1000 in their source. But also, they reserve 4000-4999 for application defined. So which way do you want to go? Use 1000 because that's the MDN defined CLOSE_NORMAL? We could define it here since sockjs doesn't yet. Or make up our own? var OCTOPRINT_CLOSE_NORMAL = 4000