Stop sockjs from multiplying on reconnect #888
Conversation
Have you ever noticed when developing that every time you stop and start the server, the terminal window gets an extra duplicate line for every reconnect attempt? Well, it's because (I think) "delete" in javascript just removes the indicated name from the namespace, it doesn't actually free up an object. Those zombie objects are still there and wake up (for some transports) on reconnect. Might be different in SockJS v1 or later.
|
Yes I have seen the terminal lines get duplicated, then triplicated, etc. On 11 May 2015 at 03:03, Mark Walker notifications@github.com wrote:
|
See https://developer.mozilla.org/en-US/docs/Web/API/CloseEvent WebSocket defines 1000 as CLOSE_NORMAL, SockJS uses it without a name and doesn't provide one for us, so for now we define our own
Have you ever noticed when developing that every time you stop and start
the server, the terminal window gets an extra duplicate line for every
reconnect attempt? Well, it's because (I think) "delete" in javascript
just removes the indicated name from the namespace, it doesn't actually
free up an object. Those zombie objects are still there and wake up (for
some transports) on reconnect. Might be different in SockJS v1 or later.
Anyway, this fixes it for me in Chrome.