This repository has been archived by the owner on Dec 6, 2018. It is now read-only.
stm32f4 IRQ manager correct static members initialization #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @vadimol |
|
|
||
| private: | ||
| //! Total IRQ count. | ||
| static constexpr auto irqs = 82; |
There was a problem hiding this comment.
we probably need some platform define like PLATFORM_IRQ_COUNT. STM32F40_41xxx and STM32F427_437xx for example has different number of interrupts
IRQ manager is a first entity that must be initialized in the system. Placement new used inside init() methods helps to avoid issues with static initialization order.
forGGe
force-pushed
the
irq_manager_correct_init
branch
from
e238bb7
to
6a458a5
Compare
Error handling improved too.
|
Looks good for me |
forGGe
added a commit
that referenced
this pull request
Apr 26, 2016
stm32f4 IRQ manager correct static members initialization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRQ manager is a first entity that must be initialized in the system.
Placement new used inside init() methods helps to avoid issues
with static initialization order.