Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed path issue in plugin #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aakashtushar
Copy link

Fixed path issue in example file.

Fixed path issue in example file.
Copy link
Member

@artfuldodger artfuldodger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't these changes break the instructions for running the example? The goal of the example is to be able to see it running locally without having to make any changes to code.

cd tinymce_equation_editor
python -m SimpleHTTPServer
# open http://localhost:8000/example/example.html

@aakashtushar
Copy link
Author

aakashtushar commented Jan 11, 2018

I thought this example was instruction to setup the plugin. I was thinking it would be easier for users if they could just download the plugin, drop the plugin in tinymce's plugin directory, load the plugin name in tinymce init and run it smoothly. I had to make those changes (like in the example) in the plugin to make it work perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants