updated README to for more clarity #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinymce.PluginManager.load('equationeditor', '/path/to/plugin.min.js') does not need anymore
artfuldodger
reviewed
Jan 8, 2018
| @@ -10,7 +10,7 @@ Equation Editor plugin for [TinyMCE](http://www.tinymce.com/) that uses [Mathqui | |||
|
|
|||
| Refer to [example/example.html](example/example.html) for an example. Note that if you have the repository cloned locally and want to see it in action, you'll need to have it running in a server (i.e. `cd tinymce_equation_editor`; `python -m SimpleHTTPServer` and then going to http://localhost:8000/example/example.html) | |||
|
|
|||
| Download [tinymce\_equation\_editor.zip](build/tinymce_equation_editor.zip). | |||
| Download [tinymce\_equation\_editor.zip](build/tinymce_equation_editor.zip) and rename to `equationeditor`. | |||
There was a problem hiding this comment.
What's the point in renaming the zip file?
There was a problem hiding this comment.
I didn't mean to rename the zip file but the folder. Don't you think, to load plugin in tinymce with 'equationeditor', folder name should be same?
| @@ -31,7 +31,6 @@ Here's an example initialization of TinyMCE. Note that you need to load equation | |||
| Anywhere that you display text that could include equations, you will need to include the Mathquill JS and CSS. | |||
|
|
|||
| ```javascript | |||
| tinymce.PluginManager.load('equationeditor', '/path/to/plugin.min.js'); | |||
There was a problem hiding this comment.
Does the equation editor JS need to be at a specific path for it to be automatically loaded now?
There was a problem hiding this comment.
tinymce will detect plugin.js or plugin.min.js if equationeditor was pointed in tinymce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tinymce.PluginManager.load('equationeditor', '/path/to/plugin.min.js') does not need anymore