Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

477/base/proposal return null #493

Merged
merged 8 commits into from
Nov 3, 2021
Merged

477/base/proposal return null #493

merged 8 commits into from
Nov 3, 2021

Conversation

yayay927
Copy link
Contributor

@yayay927 yayay927 commented Nov 2, 2021 •
edited
Loading

closes #477

Description

Checklist

  • Ran Linting
  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

ryuash
ryuash approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@ryuash ryuash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

@ryuash ryuash merged commit a186101 into base Nov 3, 2021
@ryuash ryuash deleted the 477/base/proposal-return branch November 3, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryuash ryuash ryuash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base: Handle proposals from previous blocks
2 participants
@yayay927 @ryuash